Skip to content

Commit e934540

Browse files
authored
Merge branch 'main' into fix/dype-ui-ordering
2 parents 8cb8d5f + 2102b43 commit e934540

File tree

3 files changed

+72
-4
lines changed

3 files changed

+72
-4
lines changed

.github/workflows/build-container.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,10 @@ jobs:
5353
df -h
5454
sudo rm -rf /usr/share/dotnet
5555
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
56-
sudo swapoff /mnt/swapfile
57-
sudo rm -rf /mnt/swapfile
56+
if [ -f /mnt/swapfile ]; then
57+
sudo swapoff /mnt/swapfile
58+
sudo rm -rf /mnt/swapfile
59+
fi
5860
if [ -d /mnt ]; then
5961
sudo chmod -R 777 /mnt
6062
echo '{"data-root": "/mnt/docker-root"}' | sudo tee /etc/docker/daemon.json

.github/workflows/typegen-checks.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,10 @@ jobs:
4646
df -h
4747
sudo rm -rf /usr/share/dotnet
4848
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
49-
sudo swapoff /mnt/swapfile
50-
sudo rm -rf /mnt/swapfile
49+
if [ -f /mnt/swapfile ]; then
50+
sudo swapoff /mnt/swapfile
51+
sudo rm -rf /mnt/swapfile
52+
fi
5153
echo "----- Free space after cleanup"
5254
df -h
5355
Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
# Pull Request Merge Policy
2+
3+
This document outlines the process for reviewing and merging pull requests (PRs) into the InvokeAI repository.
4+
5+
## Review Process
6+
7+
### 1. Assignment
8+
9+
One of the repository maintainers will assign collaborators to review a pull request. The assigned reviewer(s) will be responsible for conducting the code review.
10+
11+
### 2. Review and Iteration
12+
13+
The assignee is responsible for:
14+
- Reviewing the PR thoroughly
15+
- Providing constructive feedback
16+
- Iterating with the PR author until the assignee is satisfied that the PR is fit to merge
17+
- Ensuring the PR meets code quality standards, follows project conventions, and doesn't introduce bugs or regressions
18+
19+
### 3. Approval and Notification
20+
21+
Once the assignee is satisfied with the PR:
22+
- The assignee approves the PR
23+
- The assignee alerts one of the maintainers that the PR is ready for merge using the **#request-reviews Discord channel**
24+
25+
### 4. Final Merge
26+
27+
One of the maintainers is responsible for:
28+
- Performing a final check of the PR
29+
- Merging the PR into the appropriate branch
30+
31+
**Important:** Collaborators are strongly discouraged from merging PRs on their own, except in case of emergency (e.g., critical bug fix and no maintainer is available).
32+
33+
### 5. Release Policy
34+
35+
Once a feature release candidate is published, no feature PRs are to
36+
be merged into main. Only bugfixes are allowed until the final
37+
release.
38+
39+
## Best Practices
40+
41+
### Clean Commit History
42+
43+
To encourage a clean development log, PR authors are encouraged to use `git rebase -i` to suppress trivial commit messages (e.g., `ruff` and `prettier` formatting fixes) after the PR is accepted but before it is merged.
44+
45+
### Merge Strategy
46+
47+
The maintainer will perform either a **3-way merge** or **squash merge** when merging a PR into the `main` branch. This approach helps avoid rebase conflict hell and maintains a cleaner project history.
48+
49+
### Attribution
50+
51+
The PR author should reference any papers, source code or
52+
documentation that they used while creating the code both in the PR
53+
and as comments in the code itself. If there are any licensing
54+
restrictions, these should be linked to and/or reproduced in the repo
55+
root.
56+
57+
58+
## Summary
59+
60+
This policy ensures that:
61+
- All PRs receive proper review from assigned collaborators
62+
- Maintainers have final oversight before code enters the main branch
63+
- The commit history remains clean and meaningful
64+
- Merge conflicts are minimized through appropriate merge strategies

0 commit comments

Comments
 (0)