Bluetooth: conn: Fix invalid ref on conn object

andrzej-kaczmarek · carlescufi · commit b8dfecfdc57a · 2021-05-05T14:20:05.000+02:00
We should unref conn object if skipped during lookup.

Signed-off-by: Andrzej Kaczmarek &lt;andrzej.kaczmarek@codecoup.pl&gt;
diff --git a/subsys/bluetooth/host/conn.c b/subsys/bluetooth/host/conn.c
@@ -1791,7 +1791,7 @@ struct bt_conn *bt_conn_lookup_state_le(uint8_t id, const bt_addr_le_t *peer,
 		}
 
 		if (conn->type != BT_CONN_TYPE_LE) {
-			bt_conn_ref(conn);
+			bt_conn_unref(conn);
 			continue;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1791,7 +1791,7 @@ struct bt_conn bt_conn_lookup_state_le(uint8_t id, const bt_addr_le_t peer,`
`1791`	`1791`	`}`
`1792`	`1792`
`1793`	`1793`	`if (conn->type != BT_CONN_TYPE_LE) {`
`1794`		`- bt_conn_ref(conn);`
	`1794`	`+ bt_conn_unref(conn);`
`1795`	`1795`	`continue;`
`1796`	`1796`	`}`
`1797`	`1797`