Skip to content

Commit d09d455

Browse files
authored
Allow popups from iodide iframe to escape sandbox (#2919)
This makes sure forms from pages opened from an iodide report still work. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1652980
1 parent ad62a11 commit d09d455

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# (Unreleased; add upcoming change notes here)
22

3+
- Allow new windows opened from iodide to submit forms (#2919)
4+
35
# 0.20.1 (2020-05-28)
46

57
- Fix one last case where the user might be warned unnecessarily when navigating

server/notebooks/templates/notebook.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<iframe
1111
id="eval-frame"
1212
src="{{ iframe_src|safe }}"
13-
sandbox="allow-scripts allow-same-origin allow-modals allow-popups"
13+
sandbox="allow-scripts allow-same-origin allow-modals allow-popups allow-popups-to-escape-sandbox"
1414
allowfullscreen="true"
1515
allowvr="yes"
1616
allow="microphone"

src/editor/static.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<iframe
1717
id="eval-frame"
1818
src="/eval-frame/"
19-
sandbox="allow-scripts allow-modals allow-same-origin"
19+
sandbox="allow-scripts allow-same-origin allow-modals allow-popups allow-popups-to-escape-sandbox"
2020
allowfullscreen="true"
2121
allowvr="yes"
2222
></iframe>

0 commit comments

Comments
 (0)