completed routes test

Author: iolufemi

routes/index.js

@@ -51,9 +51,9 @@ router._enforceUserIdAndAppId = function(req,res,next){
     var userId = req.param('userId');
     var appId = req.param('appId');
     if(!userId){
-        res.badRequest(false,'No userId parameter was passed in the payload of this request. Please pass a userId.');
+        return res.badRequest(false,'No userId parameter was passed in the payload of this request. Please pass a userId.');
     }else if(!appId){
-        res.badRequest(false,'No appId parameter was passed in the payload of this request. Please pass an appId.');
+        return res.badRequest(false,'No appId parameter was passed in the payload of this request. Please pass an appId.');
     }else{
         req.userId = userId;
         req.appId = appId;
@@ -65,6 +65,7 @@ router._enforceUserIdAndAppId = function(req,res,next){
 router.use(function(req,res,next){
   var ipAddress = req.ip;
   req.requestId = fnv.hash(new Date().valueOf() + ipAddress, 128).str();
+  res.set('X-Request-Id',req.requestId);
 
   var reqLog = {
     RequestId: req.requestId,

test/routes/index.js

@@ -9,11 +9,17 @@ chai.use(chaiAsPromised);
 var request = require('supertest');
 var router = require('../../routes');
 var express = require('express');
+var sinon = require("sinon");
+var sinonChai = require("sinon-chai");
+chai.use(sinonChai);
 
 var app = express();
+
 app.use('/',router);
 
+
 var agent = request.agent(app);
+var requestId;
 
 describe('Test rate limiting', function(){
 
@@ -73,15 +79,95 @@ describe('Test rate limiting', function(){
         })
         .then(function(res){
             console.log('Limit: ', res.headers['x-ratelimit-limit'], '| Remaining: ', res.headers['x-ratelimit-remaining'], ' | Body: ', res.body);
+            requestId = res.headers['x-request-id'];
             done();
         })
         .catch(function(err){
             done(err);
         });
     });
+
+it('should save rate limit error on request log', function(done){
+    var RequestLog = require('../../models/RequestLogs');
+    // It takes a while for the request log to update. So let us delay the test for 1 sec
+    setTimeout(function(){
+        RequestLog.findOne({RequestId: requestId})
+        .then(function(res){
+            console.log('the request', res);
+            res.response.data.statusCode.should.equal(429);
+            done();
+        })
+        .catch(function(err){
+            done(err);
+        });
+    },1000);
+
+});
+
+var res = {};
+var req = {};
+
+var nextChecker = false;    
+var next = function(){
+    if(arguments.length > 0){
+        console.log(arguments[0]);
+    }else{
+        nextChecker = true;
+    }
+    
+    return nextChecker;
+};
+res.json = function(data){
+    return res;
+};
+
+res.badRequest = sinon.spy();
+
+res.status = function(status){
+    return res;
+};
+
+var header = {};
+res.set = function(key, value){
+    header[key] = value;
+    return header[key];
+};
+req.get = function(key){
+    return header[key];
+};
+
+header.set = function(data){
+    header.temp = data;
+    return header.temp;
+};
+
+req.method = '';
+
+it('should contain a param function', function(done){
+    router._allRequestData(req, res, next);
+    nextChecker.should.be.true; /* jslint ignore:line */
+    nextChecker = false;
+    req.param.should.be.a('function');
+    done();
 });
 
-// test rate limiting
-// Test that the request limit error is logged on the DB
-// Test allRequestData middleware
-// Test enforceUserId middleware
+it('should enforce UserId', function(done){
+    router._allRequestData(req, res, next);
+    nextChecker = false;
+    router._enforceUserIdAndAppId(req, res, next);
+    res.badRequest.should.be.called.once; /* jslint ignore:line */
+    res.badRequest.should.be.calledWith(false, 'No userId parameter was passed in the payload of this request. Please pass a userId.');
+    req.body = {};
+    req.body.userId = 'jdjdjdjd';
+    router._enforceUserIdAndAppId(req, res, next);
+    res.badRequest.should.be.called.twice; /* jslint ignore:line */
+    res.badRequest.should.be.calledWith(false, 'No appId parameter was passed in the payload of this request. Please pass an appId.');
+    nextChecker.should.be.false; /* jslint ignore:line */
+    req.body.appId = 'jdjdjdjd';
+    router._enforceUserIdAndAppId(req, res, next);
+    res.badRequest.should.be.called.twice; /* jslint ignore:line */
+    nextChecker.should.be.true; /* jslint ignore:line */
+    done();
+});
+
+});