feat(statusbar)!: make DEFAULT change style based on the Android theme (#2166)

Author: jcesarmobile

status-bar/README.md

@@ -270,11 +270,11 @@ of the space underneath it.
 
 #### Style
 
-| Members       | Value                  | Description                                                                                                                                                                                                                                            | Since |
-| ------------- | ---------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ----- |
-| **`Dark`**    | <code>'DARK'</code>    | Light text for dark backgrounds.                                                                                                                                                                                                                       | 1.0.0 |
-| **`Light`**   | <code>'LIGHT'</code>   | Dark text for light backgrounds.                                                                                                                                                                                                                       | 1.0.0 |
-| **`Default`** | <code>'DEFAULT'</code> | The style is based on the device appearance. If the device is using Dark mode, the statusbar text will be light. If the device is using Light mode, the statusbar text will be dark. On Android the default will be the one the app was launched with. | 1.0.0 |
+| Members       | Value                  | Description                                                                                                                                                                          | Since |
+| ------------- | ---------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ----- |
+| **`Dark`**    | <code>'DARK'</code>    | Light text for dark backgrounds.                                                                                                                                                     | 1.0.0 |
+| **`Light`**   | <code>'LIGHT'</code>   | Dark text for light backgrounds.                                                                                                                                                     | 1.0.0 |
+| **`Default`** | <code>'DEFAULT'</code> | The style is based on the device appearance. If the device is using Dark mode, the statusbar text will be light. If the device is using Light mode, the statusbar text will be dark. | 1.0.0 |
 
 
 #### Animation

status-bar/android/src/main/java/com/capacitorjs/plugins/statusbar/StatusBar.java

@@ -1,5 +1,6 @@
 package com.capacitorjs.plugins.statusbar;
 
+import android.content.res.Configuration;
 import android.graphics.Color;
 import android.os.Build;
 import android.util.DisplayMetrics;
@@ -21,15 +22,13 @@ public class StatusBar {
     private int currentStatusBarColor;
     private final ChangeListener listener;
     private final AppCompatActivity activity;
-    private final String defaultStyle;
+    private String currentStyle = "DEFAULT";
 
     public StatusBar(AppCompatActivity activity, StatusBarConfig config, ChangeListener listener) {
         // save initial color of the status bar
         this.activity = activity;
         this.currentStatusBarColor = activity.getWindow().getStatusBarColor();
         this.listener = listener;
-        this.defaultStyle = getStyle();
-
         setBackgroundColor(config.getBackgroundColor());
         setStyle(config.getStyle());
         setOverlaysWebView(config.isOverlaysWebView());
@@ -41,15 +40,27 @@ public StatusBar(AppCompatActivity activity, StatusBarConfig config, ChangeListe
     public void setStyle(String style) {
         Window window = activity.getWindow();
         View decorView = window.getDecorView();
-
+        this.currentStyle = style;
         if (style.equals("DEFAULT")) {
-            style = this.defaultStyle;
+            style = getStyleForTheme();
         }
 
         WindowInsetsControllerCompat windowInsetsControllerCompat = WindowCompat.getInsetsController(window, decorView);
         windowInsetsControllerCompat.setAppearanceLightStatusBars(!style.equals("DARK"));
     }
 
+    private String getStyleForTheme() {
+        int currentNightMode = activity.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
+        if (currentNightMode != Configuration.UI_MODE_NIGHT_YES) {
+            return "LIGHT";
+        }
+        return "DARK";
+    }
+
+    public void updateStyle() {
+        setStyle(this.currentStyle);
+    }
+
     @SuppressWarnings("deprecation")
     public void setBackgroundColor(int color) {
         Window window = activity.getWindow();

status-bar/android/src/main/java/com/capacitorjs/plugins/statusbar/StatusBarPlugin.java

@@ -1,5 +1,6 @@
 package com.capacitorjs.plugins.statusbar;
 
+import android.content.res.Configuration;
 import com.getcapacitor.JSObject;
 import com.getcapacitor.Logger;
 import com.getcapacitor.Plugin;
@@ -49,6 +50,12 @@ private String styleFromConfig(String style) {
         }
     }
 
+    @Override
+    protected void handleOnConfigurationChanged(Configuration newConfig) {
+        super.handleOnConfigurationChanged(newConfig);
+        implementation.updateStyle();
+    }
+
     @PluginMethod
     public void setStyle(final PluginCall call) {
         final String style = call.getString("style");

status-bar/src/definitions.ts

@@ -69,7 +69,6 @@ export enum Style {
    * The style is based on the device appearance.
    * If the device is using Dark mode, the statusbar text will be light.
    * If the device is using Light mode, the statusbar text will be dark.
-   * On Android the default will be the one the app was launched with.
    *
    * @since 1.0.0
    */