Skip to content

Fix Android Camera crash when opening photo gallery with limit#2309

Closed
joewoodhouse wants to merge 1 commit intoionic-team:mainfrom
joewoodhouse:camera-android-limit-fix
Closed

Fix Android Camera crash when opening photo gallery with limit#2309
joewoodhouse wants to merge 1 commit intoionic-team:mainfrom
joewoodhouse:camera-android-limit-fix

Conversation

@joewoodhouse
Copy link

Prevents a crash where if the user specifies a limit to pickImages that is above the system's maximum limit. Currently supplying a limit value of, say, 10,000 will result in crash with the following exception:

Max items must be less or equals MediaStore.getPickImagesMaxLimit()

This change makes the check as suggested in the error.

@eric-horodyski
Copy link
Member

As part of our effort to keep Capacitor’s backlog healthy and aligned with current development, pull requests older than 12 months are being closed during this cleanup initiative.

More context:
https://ionic.io/blog/keeping-capacitors-backlog-healthy

If you’d like to pursue this change, please open a new PR against the current main branch and we’ll review it in the context of the latest codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants