fix: migrate root Ionic module without config (#40)

* fix: migrate root Ionic module without config

* chore: improve error messages

Author: sean-perkins

packages/cli/src/angular/migrations/standalone/0003-migrate-bootstrap-application.test.ts

@@ -116,4 +116,65 @@ describe("migrateBootstrapApplication", () => {
     `),
     );
   });
+
+  it("should migrate IonicModule.forRoot without explicit config", async () => {
+    const project = new Project({ useInMemoryFileSystem: true });
+
+    const main = dedent(`
+    import { enableProdMode, importProvidersFrom } from '@angular/core';
+    import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
+
+
+    import { environment } from './environments/environment';
+    import { AppComponent } from './app/app.component';
+    import { AppRoutingModule } from './app/app-routing.module';
+    import { BrowserModule, bootstrapApplication } from '@angular/platform-browser';
+    import { IonicRouteStrategy, IonicModule } from '@ionic/angular';
+    import { RouteReuseStrategy } from '@angular/router';
+
+    if (environment.production) {
+      enableProdMode();
+    }
+
+    bootstrapApplication(AppComponent, {
+        providers: [
+            importProvidersFrom(BrowserModule, IonicModule.forRoot(), AppRoutingModule),
+            { provide: RouteReuseStrategy, useClass: IonicRouteStrategy }
+        ]
+    })
+      .catch(err => console.log(err));
+    `);
+
+    const mainSourceFile = project.createSourceFile("src/main.ts", main);
+
+    await migrateBootstrapApplication(project, { dryRun: false });
+
+    expect(dedent(mainSourceFile.getText())).toBe(
+      dedent(`
+      import { enableProdMode, importProvidersFrom } from '@angular/core';
+      import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
+      
+      
+      import { environment } from './environments/environment';
+      import { AppComponent } from './app/app.component';
+      import { AppRoutingModule } from './app/app-routing.module';
+      import { BrowserModule, bootstrapApplication } from '@angular/platform-browser';
+      import { IonicRouteStrategy, provideIonicAngular } from '@ionic/angular/standalone';
+      import { RouteReuseStrategy } from '@angular/router';
+      
+      if (environment.production) {
+          enableProdMode();
+      }
+      
+      bootstrapApplication(AppComponent, {
+          providers: [
+              importProvidersFrom(BrowserModule, AppRoutingModule),
+              { provide: RouteReuseStrategy, useClass: IonicRouteStrategy },
+              provideIonicAngular({})
+          ]
+      })
+          .catch(err => console.log(err));
+      `),
+    );
+  });
 });

packages/cli/src/angular/migrations/standalone/0003-migrate-bootstrap-application.ts

@@ -129,9 +129,9 @@ export const migrateBootstrapApplication = async (
       const ionicConfigObjectLiteralExpression =
         importProvidersFromFunctionCallIonicModuleForRootCallExpressionArguments[0];
 
-      providersArray.addElement(
-        `provideIonicAngular(${ionicConfigObjectLiteralExpression.getText()})`,
-      );
+      const ionicConfig = ionicConfigObjectLiteralExpression?.getText() ?? "{}";
+
+      providersArray.addElement(`provideIonicAngular(${ionicConfig})`);
 
       // Remove the IonicModule.forRoot from the importProvidersFrom function call.
       importProvidersFromFunctionCall.removeArgument(

packages/cli/src/index.ts

@@ -96,9 +96,10 @@ async function main() {
       dir: cli.dir,
       spinner: s,
     });
-  } catch (e: any) {
+  } catch (e) {
     s.stop("An error occurred during the migration.", 1);
-    log.error(e.message);
+    const error = e as Error;
+    log.error(error.stack ?? error.message);
   }
 
   outro(