fix(login): show error message from login results on login failure.

Author: jthoms1

lib/ionic/login.js

@@ -45,11 +45,7 @@ function login(argv) {
     return cookieJar;
   })
   .catch(function(ex) {
-    log.error('Error logging in');
-    throw ex;
-
-    // log.info(ex);
-    // log.info(ex.stack);
+    log.error(ex);
   });
 }
 

spec/tasks/login.spec.js

@@ -118,21 +118,18 @@ describe('login command', function() {
       });
     });
 
-    it('should throw an error on a failed log in', function(done) {
+    it('should display the error on a failed log in attempt', function(done) {
       var processArguments = ['node', 'ionic', 'login', '--email', '[email protected]', '--password', 'asdf1234'];
       var rawCliArguments = processArguments.slice(2);
       var argv = optimist(rawCliArguments).argv;
 
-      var error = new Error('error occurred');
+      var error = 'Email or Password incorrect. Please visit';
       spyOn(log, 'error');
       spyOn(login, 'promptForLogin');
-      spyOn(appLibLogin, 'requestLogIn').andCallFake(function() {
-        throw error;
-      });
+      spyOn(appLibLogin, 'requestLogIn').andReturn(Q.reject(error));
 
-      login.login(argv).catch(function(err) {
-        expect(log.error).toHaveBeenCalledWith('Error logging in');
-        expect(err).toEqual(error);
+      login.login(argv).then(function() {
+        expect(log.error).toHaveBeenCalledWith(error);
         done();
       });
     });
@@ -159,25 +156,5 @@ describe('login command', function() {
         done();
       });
     });
-
-    it('should return a rejected promise on failure', function(done) {
-      var processArguments = ['node', 'ionic', 'login'];
-      var rawCliArguments = processArguments.slice(2);
-      var argv = optimist(rawCliArguments).argv;
-
-      spyOn(log, 'info');
-      spyOn(prompt, 'start');
-      spyOn(prompt, 'get').andCallFake(function(schema, callback) {
-        callback('an error occurred', null);
-      });
-
-      var promptForLogin = login.__get__('promptForLogin');
-
-      promptForLogin(argv).catch(function(results) {
-        expect(prompt.get).toHaveBeenCalled();
-        expect(results).toEqual('Error logging in: an error occurred');
-        done();
-      });
-    });
   });
 });