chore(tests): add tests to increase coverage on login, plugin and resources.

Author: jthoms1

spec/tasks/login.spec.js

@@ -156,5 +156,26 @@ describe('login command', function() {
         done();
       });
     });
+
+    it('should ask for email and password and eject an error if error', function(done) {
+      var processArguments = ['node', 'ionic', 'login'];
+      var rawCliArguments = processArguments.slice(2);
+      var argv = optimist(rawCliArguments).argv;
+      var error = 'error logging in';
+
+      spyOn(log, 'info');
+      spyOn(prompt, 'start');
+      spyOn(prompt, 'get').andCallFake(function(schema, callback) {
+        callback(error);
+      });
+
+      var promptForLogin = login.__get__('promptForLogin');
+
+      promptForLogin(argv).catch(function(error) {
+        expect(prompt.get).toHaveBeenCalled();
+        expect(error).toEqual(error);
+        done();
+      });
+    });
   });
 });

spec/tasks/plugin.spec.js

@@ -111,6 +111,24 @@ describe('plugin command', function() {
       });
     });
 
+    it('should add array of variables', function(done) {
+      var processArguments = ['node', 'ionic', 'plugin', 'add', 'thing', '--variable', 'hello', '--variable', 'man'];
+      var rawCliArguments = processArguments.slice(2);
+      var argv = optimist(rawCliArguments).argv;
+
+      spyOn(State, 'savePlugin');
+      spyOn(State, 'removePlugin');
+      spyOn(cordovaUtils, 'execCordovaCommand').andReturn(Q(0));
+
+      plugin.run(null, argv, rawCliArguments).then(function() {
+        expect(cordovaUtils.execCordovaCommand).toHaveBeenCalledWith(
+          ['plugin', 'add', 'thing', '--variable', 'hello', '--variable', 'man']);
+        expect(State.savePlugin).toHaveBeenCalledWith(appDirectory, 'thing', ['hello', 'man']);
+        expect(State.removePlugin).not.toHaveBeenCalled();
+        done();
+      });
+    });
+
     it('should add plugins', function(done) {
       var processArguments = ['node', 'ionic', 'plugin', 'add', 'thing', '--variable', 'hello'];
       var rawCliArguments = processArguments.slice(2);

spec/tasks/resources.spec.js

@@ -65,6 +65,24 @@ describe('resources command', function() {
       });
     });
 
+    it('should fail if applib generate fails and not log error if not instanceof Error', function(done) {
+      var processArguments = ['node', 'ionic', 'resources'];
+      var rawCliArguments = processArguments.slice(2);
+      var argv = optimist(rawCliArguments).argv;
+
+      var error = 'an error occurred';
+      spyOn(process, 'cwd').andReturn('/current/directory');
+      spyOn(Project, 'load');
+      spyOn(IonicResources, 'generate').andReturn(Q.reject(error));
+      spyOn(appLibUtils, 'fail');
+
+      // Expect failure
+      resources.run(null, argv, rawCliArguments).then(function() {
+        expect(appLibUtils.fail).not.toHaveBeenCalled();
+        done();
+      });
+    });
+
     it('should pass platforms on to the applib generate', function(done) {
       var processArguments = ['node', 'ionic', 'resources', '--icon'];
       var rawCliArguments = processArguments.slice(2);