docs(vue): show complete code context in the "Your First App" tutorial #4197
Conversation
…t in your first app page 1
|
@soundproofboot is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
I noticed that some method names from the Angular version and Vue version do not match even though they have the same code. For example, addNewToGallery from Angular and usePhotoGallery from Vue. Let's also sync those to match Angular as close as possible.
The same goes for the <title>. Let's match it to Angular.
Lastly, some of the content also doesn't match each other. A good example, Angular Build Your First App mentions:
We put the visual aspects of our app into <ion-content>. In this case, it’s where we’ll add a button that opens the device’s camera as well as displays the image captured by the camera. Start by adding a [floating action button](https://ionicframework.com/docs/api/fab) (FAB) to the bottom of the page and set the camera image as the icon.
While Vue states:
We put the visual aspects of our app into <ion-content>. In this case, it’s where we’ll add a button that opens the device’s camera as well as displays the image captured by the camera. But first, remove both the ExploreContainer component and its import statement:
It should match the steps of Angular.
|
@thetaPC Hi Maria, I tried to make the titles match in Vue and added some On making the steps match Angular, there are more steps required for Vue in that specific case so I think they are slightly reordered to clarify what's being removed and added in Vue (as in remove these two things before we add these other several things) vs. Angular, where I was able to clearly indicate what to remove and add in one code block. I have not looked at this in a while so it may take me a minute to familiarize myself with the frameworks and changes but I'm willing to keep working on this if there are other suggestions. |
resolves #4165
Changes