Skip to content

Commit 02c1388

Browse files
BenOsodracIonitron
andauthored
fix(tokens): fix usage on components and review scss architecture (#30368)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Added improvements on scss architecture, as identified on past assessment, on multiple components. Some of these changes resulted in snapshots differences, all reviewed and expected: - Button spinner - pics with no visual differences/false-positive. - Item slider - difference due to updated typography token. - Item - difference as is now using correct disabled styles tokens. - searchbar: 1px difference on horizontal margin - expected - to start using a more rounded value from a token. - Tab/tab-button - difference as is now using correct typography token. - Spinner/loading - this looks like a false positive, saw no visible differences. - Textarea - this looks like a false positive, saw no visible differences. - Typography - this looks like a false positive, saw no visible differences. ## Does this introduce a breaking change? - [x] Yes - [ ] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> --------- Co-authored-by: ionitron <[email protected]>
1 parent 1e7a84f commit 02c1388

File tree

723 files changed

+634
-456
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

723 files changed

+634
-456
lines changed

core/api.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1707,10 +1707,8 @@ ion-progress-bar,prop,shape,"rectangular" | "round" | undefined,undefined,false,
17071707
ion-progress-bar,prop,theme,"ios" | "md" | "ionic",undefined,false,false
17081708
ion-progress-bar,prop,type,"determinate" | "indeterminate",'determinate',false,false
17091709
ion-progress-bar,prop,value,number,0,false,false
1710-
ion-progress-bar,css-prop,--background,ionic
17111710
ion-progress-bar,css-prop,--background,ios
17121711
ion-progress-bar,css-prop,--background,md
1713-
ion-progress-bar,css-prop,--progress-background,ionic
17141712
ion-progress-bar,css-prop,--progress-background,ios
17151713
ion-progress-bar,css-prop,--progress-background,md
17161714
ion-progress-bar,part,progress

core/src/components/accordion-group/accordion-group.ionic.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
// --------------------------------------------------
66

77
:host {
8-
min-width: 272px;
8+
min-width: calc(#{globals.$ion-scale-6200} + #{globals.$ion-space-600});
99

10-
background-color: globals.$ion-primitives-base-white;
10+
background-color: globals.$ion-bg-neutral-subtlest-default;
1111
}
1212

1313
// Inset Accordion Group

0 commit comments

Comments
 (0)