Skip to content

Commit 03c4afc

Browse files
author
Tanner Reits
committed
fix: add .ion-app to query lists
1 parent 9390969 commit 03c4afc

File tree

8 files changed

+10
-10
lines changed

8 files changed

+10
-10
lines changed

core/api.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ ion-infinite-scroll-content,prop,loadingText,IonicSafeString | string | undefine
695695

696696
ion-input,scoped
697697
ion-input,prop,autocapitalize,string,'off',false,false
698-
ion-input,prop,autocomplete,"name" | "email" | "tel" | "url" | "on" | "off" | "honorific-prefix" | "given-name" | "additional-name" | "family-name" | "honorific-suffix" | "nickname" | "username" | "new-password" | "current-password" | "one-time-code" | "organization-title" | "organization" | "street-address" | "address-line1" | "address-line2" | "address-line3" | "address-level4" | "address-level3" | "address-level2" | "address-level1" | "country" | "country-name" | "postal-code" | "cc-name" | "cc-given-name" | "cc-additional-name" | "cc-family-name" | "cc-number" | "cc-exp" | "cc-exp-month" | "cc-exp-year" | "cc-csc" | "cc-type" | "transaction-currency" | "transaction-amount" | "language" | "bday" | "bday-day" | "bday-month" | "bday-year" | "sex" | "tel-country-code" | "tel-national" | "tel-area-code" | "tel-local" | "tel-extension" | "impp" | "photo",'off',false,false
698+
ion-input,prop,autocomplete,"name" | "url" | "off" | "on" | "additional-name" | "address-level1" | "address-level2" | "address-level3" | "address-level4" | "address-line1" | "address-line2" | "address-line3" | "bday-day" | "bday-month" | "bday-year" | "cc-csc" | "cc-exp" | "cc-exp-month" | "cc-exp-year" | "cc-family-name" | "cc-given-name" | "cc-name" | "cc-number" | "cc-type" | "country" | "country-name" | "current-password" | "family-name" | "given-name" | "honorific-prefix" | "honorific-suffix" | "new-password" | "one-time-code" | "organization" | "postal-code" | "street-address" | "transaction-amount" | "transaction-currency" | "username" | "email" | "tel" | "tel-area-code" | "tel-country-code" | "tel-extension" | "tel-local" | "tel-national" | "nickname" | "organization-title" | "cc-additional-name" | "language" | "bday" | "sex" | "impp" | "photo",'off',false,false
699699
ion-input,prop,autocorrect,"off" | "on",'off',false,false
700700
ion-input,prop,autofocus,boolean,false,false,false
701701
ion-input,prop,clearInput,boolean,false,false,false
@@ -1476,7 +1476,7 @@ ion-row,shadow
14761476
ion-searchbar,scoped
14771477
ion-searchbar,prop,animated,boolean,false,false,false
14781478
ion-searchbar,prop,autocapitalize,string,'off',false,false
1479-
ion-searchbar,prop,autocomplete,"name" | "email" | "tel" | "url" | "on" | "off" | "honorific-prefix" | "given-name" | "additional-name" | "family-name" | "honorific-suffix" | "nickname" | "username" | "new-password" | "current-password" | "one-time-code" | "organization-title" | "organization" | "street-address" | "address-line1" | "address-line2" | "address-line3" | "address-level4" | "address-level3" | "address-level2" | "address-level1" | "country" | "country-name" | "postal-code" | "cc-name" | "cc-given-name" | "cc-additional-name" | "cc-family-name" | "cc-number" | "cc-exp" | "cc-exp-month" | "cc-exp-year" | "cc-csc" | "cc-type" | "transaction-currency" | "transaction-amount" | "language" | "bday" | "bday-day" | "bday-month" | "bday-year" | "sex" | "tel-country-code" | "tel-national" | "tel-area-code" | "tel-local" | "tel-extension" | "impp" | "photo",'off',false,false
1479+
ion-searchbar,prop,autocomplete,"name" | "url" | "off" | "on" | "additional-name" | "address-level1" | "address-level2" | "address-level3" | "address-level4" | "address-line1" | "address-line2" | "address-line3" | "bday-day" | "bday-month" | "bday-year" | "cc-csc" | "cc-exp" | "cc-exp-month" | "cc-exp-year" | "cc-family-name" | "cc-given-name" | "cc-name" | "cc-number" | "cc-type" | "country" | "country-name" | "current-password" | "family-name" | "given-name" | "honorific-prefix" | "honorific-suffix" | "new-password" | "one-time-code" | "organization" | "postal-code" | "street-address" | "transaction-amount" | "transaction-currency" | "username" | "email" | "tel" | "tel-area-code" | "tel-country-code" | "tel-extension" | "tel-local" | "tel-national" | "nickname" | "organization-title" | "cc-additional-name" | "language" | "bday" | "sex" | "impp" | "photo",'off',false,false
14801480
ion-searchbar,prop,autocorrect,"off" | "on",'off',false,false
14811481
ion-searchbar,prop,cancelButtonIcon,string,config.get('backButtonIcon', arrowBackSharp) as string,false,false
14821482
ion-searchbar,prop,cancelButtonText,string,'Cancel',false,false

core/src/components/content/content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ const getPageElement = (el: HTMLElement) => {
515515
* between the popover and the edges of the screen. But if the popover contains
516516
* its own page element, we should use that instead.
517517
*/
518-
const page = el.closest('ion-app, ion-page, .ion-page, page-inner, .popover-content');
518+
const page = el.closest('ion-app, .ion-app, ion-page, .ion-page, page-inner, .popover-content');
519519
if (page) {
520520
return page;
521521
}

core/src/components/footer/footer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export class Footer implements ComponentInterface {
8484
this.destroyCollapsibleFooter();
8585

8686
if (hasFade) {
87-
const pageEl = this.el.closest('ion-app,ion-page,.ion-page,page-inner');
87+
const pageEl = this.el.closest('ion-app,.ion-app,ion-page,.ion-page,page-inner');
8888
const contentEl = pageEl ? findIonContent(pageEl) : null;
8989

9090
if (!contentEl) {

core/src/components/header/header.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export class Header implements ComponentInterface {
8484
this.destroyCollapsibleHeader();
8585

8686
if (hasCondense) {
87-
const pageEl = this.el.closest('ion-app,ion-page,.ion-page,page-inner');
87+
const pageEl = this.el.closest('ion-app,.ion-app,ion-page,.ion-page,page-inner');
8888
const contentEl = pageEl ? findIonContent(pageEl) : null;
8989

9090
// Cloned elements are always needed in iOS transition
@@ -96,7 +96,7 @@ export class Header implements ComponentInterface {
9696

9797
await this.setupCondenseHeader(contentEl, pageEl);
9898
} else if (hasFade) {
99-
const pageEl = this.el.closest('ion-app,ion-page,.ion-page,page-inner');
99+
const pageEl = this.el.closest('ion-app,.ion-app,ion-page,.ion-page,page-inner');
100100
const contentEl = pageEl ? findIonContent(pageEl) : null;
101101

102102
if (!contentEl) {

core/src/utils/framework-delegate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export const CoreDelegate = () => {
128128
* Get the root of the app and
129129
* add the overlay there.
130130
*/
131-
const app = document.querySelector('ion-app') || document.body;
131+
const app = document.querySelector('ion-app, .ion-app') || document.body;
132132

133133
/**
134134
* Create a placeholder comment so that

core/src/utils/helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ export const focusVisibleElement = (el: HTMLElement) => {
266266
* which will let us explicitly set the elements to focus.
267267
*/
268268
if (el.classList.contains('ion-focusable')) {
269-
const app = el.closest('ion-app');
269+
const app = el.closest('ion-app, .ion-app') as HTMLIonAppElement | null;
270270
if (app) {
271271
app.setFocus([el]);
272272
}

core/src/utils/keyboard/keyboard-controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const getResizeContainer = (resizeMode?: KeyboardResize): HTMLElement | null =>
2525
* on that. In the event `ion-app` is not available then
2626
* we can fall back to `body`.
2727
*/
28-
const ionApp = doc.querySelector('ion-app');
28+
const ionApp = doc.querySelector('ion-app, .ion-app') as HTMLIonAppElement | null;
2929

3030
return ionApp ?? doc.body;
3131
};

core/src/utils/overlays.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ export const dismiss = async <OverlayDismissOptions>(
697697
};
698698

699699
const getAppRoot = (doc: Document) => {
700-
return doc.querySelector('ion-app') || doc.body;
700+
return doc.querySelector('ion-app, .ion-app') || doc.body;
701701
};
702702

703703
const overlayAnimation = async (

0 commit comments

Comments
 (0)