fix(modal): updating tests, making tabIndex condition more specific

Author: ShaneK

core/src/components/modal/modal.tsx

@@ -965,12 +965,13 @@ export class Modal implements ComponentInterface, OverlayInterface {
     const mode = getIonMode(this);
     const isCardModal = presentingElement !== undefined && mode === 'ios';
     const isHandleCycle = handleBehavior === 'cycle';
+    const isSheetModalWithHandle = isSheetModal && showHandle;
 
     return (
       <Host
         no-router
         // Allow the modal to be navigable when the handle is focusable
-        tabIndex={!isHandleCycle ? -1 : 0}
+        tabIndex={isHandleCycle && isSheetModalWithHandle ? 0 : -1}
         {...(htmlAttributes as any)}
         style={{
           zIndex: `${20000 + this.overlayIndex}`,

core/src/components/modal/test/sheet/index.html

@@ -107,7 +107,7 @@
             Present Sheet Modal (Scroll at any breakpoint)
           </button>
           <button
-            id="scroll-at-edge-modal"
+            id="cycle-scroll-no-backdrop"
             onclick="presentModal({ handleBehavior: 'cycle', backdropBreakpoint: 1, backdropDismiss: false, initialBreakpoint: 0.5, breakpoints: [0, 0.25, 0.5, 0.75, 1], expandToScroll: false })"
           >
             Present Sheet Modal (Cycle Handle, Scroll at any breakpoint)