Skip to content

Commit 1015c06

Browse files
authored
chore(react): update sync script to use tgz (#28019)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The sync script for the React package is out of date. It will unintentionally delete the symlink directory of the build output from `core/`, which breaks the build for the package during local development. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates the sync script to package and install the `core` package - Matches the implementation pattern used for the sync script in our other packages ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent 6bcefcd commit 1015c06

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

packages/react/scripts/sync.sh

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,11 @@
22

33
set -e
44

5-
# Copy core dist
6-
rm -rf node_modules/@ionic/core/dist node_modules/@ionic/core/components
7-
cp -a ../../core/dist node_modules/@ionic/core/dist
8-
cp -a ../../core/components node_modules/@ionic/core/components
9-
cp -a ../../core/package.json node_modules/@ionic/core/package.json
5+
# Delete old packages
6+
rm -f *.tgz
7+
8+
# Pack @ionic/core
9+
npm pack ../../core
10+
11+
# Install Dependencies
12+
npm install *.tgz --no-save

0 commit comments

Comments
 (0)