Skip to content

Commit 17dc854

Browse files
committed
test(select): fix duplicated tests
1 parent 5d719ba commit 17dc854

File tree

2 files changed

+1
-58
lines changed

2 files changed

+1
-58
lines changed

core/src/components/select/test/color/select.e2e.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ configs({ modes: ['md', 'ionic-md'], directions: ['ltr'] }).forEach(({ title, sc
77
test('should set label and highlight color on expand', async ({ page }) => {
88
await page.setContent(
99
`
10-
<ion-select fill="outline" label="Label" class="select-expanded" value="apple" class="ion-focused" color="danger">
10+
<ion-select fill="outline" label="Label" class="select-expanded" value="apple" class="has-focus" color="danger">
1111
<ion-select-option value="apple">Apple</ion-select-option>
1212
</ion-select>
1313
`,
@@ -53,20 +53,5 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co
5353
await expect(select).toHaveScreenshot(screenshot(`select-solid-color`));
5454
});
5555
});
56-
test.describe('input: fill outline', () => {
57-
test('should set label and highlight color on expand', async ({ page }) => {
58-
await page.setContent(
59-
`
60-
<ion-select fill="outline" label="Label" class="select-expanded" value="apple" class="has-focus" color="danger">
61-
<ion-select-option value="apple">Apple</ion-select-option>
62-
</ion-select>
63-
`,
64-
config
65-
);
66-
67-
const select = page.locator('ion-select');
68-
await expect(select).toHaveScreenshot(screenshot(`select-outline-color`));
69-
});
70-
});
7156
});
7257
});

core/src/components/select/test/highlight/select.e2e.ts

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -268,48 +268,6 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co
268268
});
269269
});
270270
});
271-
272-
test.describe(title('select: expanded highlight'), () => {
273-
test.describe('select: no fill', () => {
274-
test('should render bottom highlight', async ({ page }) => {
275-
await page.setContent(
276-
`
277-
<ion-select label="Label" class="select-expanded"></ion-select>
278-
`,
279-
config
280-
);
281-
282-
const select = page.locator('ion-select');
283-
await expect(select).toHaveScreenshot(screenshot(`select-no-fill-highlight`));
284-
});
285-
});
286-
test.describe('select: solid', () => {
287-
test('should render bottom highlight', async ({ page }) => {
288-
await page.setContent(
289-
`
290-
<ion-select fill="solid" label="Label" class="select-expanded"></ion-select>
291-
`,
292-
config
293-
);
294-
295-
const select = page.locator('ion-select');
296-
await expect(select).toHaveScreenshot(screenshot(`select-solid-highlight`));
297-
});
298-
});
299-
test.describe('select: outline', () => {
300-
test('should render bottom highlight', async ({ page }) => {
301-
await page.setContent(
302-
`
303-
<ion-select fill="outline" label="Label" class="select-expanded"></ion-select>
304-
`,
305-
config
306-
);
307-
308-
const select = page.locator('ion-select');
309-
await expect(select).toHaveScreenshot(screenshot(`select-outline-highlight`));
310-
});
311-
});
312-
});
313271
});
314272

315273
configs({ modes: ['md', 'ionic-md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {

0 commit comments

Comments
 (0)