Skip to content

Commit 196a22e

Browse files
authored
chore: fallback to framework team with codeowners (#28588)
I noticed that Dependabot PRs never had anyone assigned: #28586 The reason was that we removed `* @ionic-team/framework` when we adjusted the codeowners in #27573. My original reasoning for why we should remove it was wrong. GitHub only assigns reviewers within a team if the team itself is assigned. By removing the team from being reviewed, only people listed in the codeowners file would be assigned. As an added example, PRs that do not match codeowners currently have no one assigned: #28430
1 parent 01130e1 commit 196a22e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.github/CODEOWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
# In each subsection folders are ordered first by depth, then alphabetically.
1212
# This should make it easy to add new rules without breaking existing ones.
1313

14+
* @ionic-team/framework
15+
1416
# Frameworks
1517

1618
## Angular

0 commit comments

Comments
 (0)