Skip to content

Commit 1bfc859

Browse files
committed
chore: revert tap tolerance fix for now
1 parent fa8aa6a commit 1bfc859

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

js/utils/tap.js

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@ var tapTouchFocusedInput;
7878
var tapLastTouchTarget;
7979
var tapTouchMoveListener = 'touchmove';
8080

81-
// how much the coordinates can be off between start/end, but still a click
82-
var TAP_RELEASE_TOLERANCE = 6; // default tolerance
83-
var TAP_RELEASE_BUTTON_TOLERANCE = 50; // button elements should have a larger tolerance
81+
var TAP_RELEASE_TOLERANCE = 6; // how much the coordinates can be off between start/end, but still a click
8482

8583
var tapEventListeners = {
8684
'click': tapClickGateKeeper,
@@ -236,9 +234,8 @@ ionic.tap = {
236234
return false;
237235
},
238236

239-
setTolerance: function(releaseTolerance, releaseButtonTolerance) {
240-
TAP_RELEASE_TOLERANCE = releaseTolerance;
241-
TAP_RELEASE_BUTTON_TOLERANCE = releaseButtonTolerance;
237+
setTolerance: function(val) {
238+
TAP_RELEASE_TOLERANCE = val;
242239
}
243240

244241
};
@@ -505,10 +502,8 @@ function tapHasPointerMoved(endEvent) {
505502
}
506503
var endCoordinates = getPointerCoordinates(endEvent);
507504

508-
var releaseTolerance = (endEvent.target.classList.contains('button') ? TAP_RELEASE_BUTTON_TOLERANCE : TAP_RELEASE_TOLERANCE);
509-
510-
return Math.abs(tapPointerStart.x - endCoordinates.x) > releaseTolerance ||
511-
Math.abs(tapPointerStart.y - endCoordinates.y) > releaseTolerance;
505+
return Math.abs(tapPointerStart.x - endCoordinates.x) > TAP_RELEASE_TOLERANCE ||
506+
Math.abs(tapPointerStart.y - endCoordinates.y) > TAP_RELEASE_TOLERANCE;
512507
}
513508

514509
function getPointerCoordinates(event) {

0 commit comments

Comments
 (0)