Skip to content

Commit 2007a44

Browse files
brandyscarneysean-perkins
brandyscarney
and
sean-perkins
authored
test(many): fix failing tests that CI was not reporting (#29485)
Code checks were passing even though these tests were failing because the docker script was not exiting with the correct exit code. This PR fixes the tests so that they pass, then PR #29425 can be merged so CI will properly fail again when tests fail. --------- Co-authored-by: Sean Perkins <[email protected]>
1 parent 704765e commit 2007a44

File tree

41 files changed

+42
-36
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+42
-36
lines changed

‎core/src/components/accordion/test/a11y/accordion.e2e.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ import { configs, test } from '@utils/test/playwright';
33

44
configs().forEach(({ config, title }) => {
55
test.describe(title('accordion: a11y'), () => {
6-
test('accordions should be keyboard navigable', async ({ page, skip, browserName }) => {
7-
// TODO(FW-1764): remove skip once issue is resolved
6+
// TODO(ROU-8157): remove skip once the keyboard navigation is working again
7+
test.skip('accordions should be keyboard navigable', async ({ page, skip, browserName }) => {
8+
// TODO(ROU-5358): remove skip once issue is resolved
89
skip.browser('firefox', 'https://github.com/ionic-team/ionic-framework/issues/25070');
9-
// TODO (FW-2979)
10+
// TODO (ROU-5437)
1011
skip.browser('webkit', 'Safari 16 only allows text fields and pop-up menus to be focused.');
1112

1213
await page.goto(`/src/components/accordion/test/a11y`, config);

‎core/src/components/accordion/test/standalone/index.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html lang="en" dir="ltr">
33
<head>
44
<meta charset="UTF-8" />
5-
<title>Accordion - Basic</title>
5+
<title>Accordion - Standalone</title>
66
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" />
77
<link href="../../../../../css/ionic.bundle.css" rel="stylesheet" />
88
<link href="../../../../../scripts/testing/styles.css" rel="stylesheet" />
@@ -119,6 +119,7 @@ <h2>Margins In Content</h2>
119119
outline: none;
120120
text-align: left;
121121
padding: 20px 16px;
122+
color: black;
122123
}
123124

124125
.custom-accordion-content {

‎core/src/components/alert/test/a11y/alert.e2e.ts-snapshots/alert-scale-ios-ltr-Mobile-Chrome-linux.png

-14 Bytes

‎core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, screenshot, t
1111
test('should update the active item', async ({ page }) => {
1212
const breadcrumbItems = page.locator('ion-breadcrumb');
1313

14-
const addItemButton = page.locator('ion-button#add-btn');
14+
const addItemButton = page.locator('#add-btn');
1515

1616
await expect(breadcrumbItems).toHaveCount(4);
1717

‎core/src/components/datetime/test/position/datetime.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ configs().forEach(({ title, screenshot, config }) => {
77
await page.goto('/src/components/datetime/test/position', config);
88
const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent');
99

10-
const openDateTimeBtn = page.locator('ion-button#open-datetime');
10+
const openDateTimeBtn = page.locator('#open-datetime');
1111
await openDateTimeBtn.click();
1212

1313
await ionPopoverDidPresent.next();

‎core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Chrome-linux.png

-257 Bytes

‎core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Firefox-linux.png

-422 Bytes

‎core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Safari-linux.png

-127 Bytes

‎core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Chrome-linux.png

-262 Bytes

‎core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Firefox-linux.png

134 Bytes

0 commit comments

Comments
 (0)