Commit 2228831
authored
chore(deps): add playwright-core as a dev dependency (#30827)
This updates the `package-lock` file to match the structure `next` uses
so we won't have a mismatch with errors on each branch. It installs
`playwright-core` as a dev dependency to align with `next`.
How to test this:
1. Switch to this branch `chore/deps-playwright`
1. Remove `node_modules`: `rm -rf node_modules`
1. Run `npx lerna@5 bootstrap --include-dependencies --scope @ionic/core
--ignore-scripts -- --legacy-peer-deps && npm run build`
1. ✅ Verify: build is successful
1. Run `git revert 76cf4bd`
1. Run `npx lerna@5 bootstrap --include-dependencies --scope @ionic/core
--ignore-scripts -- --legacy-peer-deps && npm run build`
1. 🛑 Verify: the following error occurs:
```bash
[ ERROR ] TypeScript:
node_modules/@axe-core/playwright/dist/index.d.ts:2:22
Cannot find module 'playwright-core' or its corresponding
type declarations.
L1: import { SerialFrameSelector, RunOptions, AxeResults } from
'axe-core';
L2: import { Page } from 'playwright-core';
[00:58.9] build failed in 6.36 s
```
1 parent c65b76e commit 2228831
2 files changed
+1061
-9575
lines changed
0 commit comments