Skip to content

Commit 2d5aa94

Browse files
CR
1 parent 79d5e31 commit 2d5aa94

18 files changed

+20
-29
lines changed

core/src/components.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2610,7 +2610,7 @@ export namespace Components {
26102610
*/
26112611
"reversed": boolean;
26122612
/**
2613-
* Set to `"round"` for a tab-button with rounded corners, or `"rectangular"` for a tab-button without rounded corners. Defaults to `"round"` for the `ionic` theme, undefined for all other themes.
2613+
* Set to `"round"` for a progress-bar with rounded corners, or `"rectangular"` for a progress-bar without rounded corners. Defaults to `"round"` for the `ionic` theme, undefined for all other themes.
26142614
*/
26152615
"shape"?: 'round' | 'rectangular';
26162616
/**
@@ -7964,7 +7964,7 @@ declare namespace LocalJSX {
79647964
*/
79657965
"reversed"?: boolean;
79667966
/**
7967-
* Set to `"round"` for a tab-button with rounded corners, or `"rectangular"` for a tab-button without rounded corners. Defaults to `"round"` for the `ionic` theme, undefined for all other themes.
7967+
* Set to `"round"` for a progress-bar with rounded corners, or `"rectangular"` for a progress-bar without rounded corners. Defaults to `"round"` for the `ionic` theme, undefined for all other themes.
79687968
*/
79697969
"shape"?: 'round' | 'rectangular';
79707970
/**

core/src/components/progress-bar/progress-bar.ionic.scss

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
11
@use "../../themes/ionic/ionic.globals.scss" as globals;
2-
@import "./progress-bar";
2+
@use "./progress-bar";
33

4-
// iOS Progress bar
4+
// Ionic Progress bar
55
// --------------------------------------------------
66

77
:host {
8-
height: globals.$ion-scale-100;
9-
}
10-
11-
:host(.progress-bar-solid) {
12-
/**
13-
* On the ionic theme the unfilled portion of the progress
14-
* bar is always a consistent background color. We
15-
* only apply this style when the progress bar is
16-
* solid (with a buffer value of 1). This maintains
17-
* the custom Ionic appearance for a buffered progress bar.
18-
*/
198
--background: #{globals.$ion-primitives-neutral-100};
9+
10+
height: globals.$ion-scale-100;
2011
}
2112

2213
// Progress Bar Shapes

core/src/components/progress-bar/progress-bar.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ export class ProgressBar implements ComponentInterface {
5858
@Prop({ reflect: true }) color?: Color;
5959

6060
/**
61-
* Set to `"round"` for a tab-button with rounded corners, or `"rectangular"`
62-
* for a tab-button without rounded corners.
61+
* Set to `"round"` for a progress-bar with rounded corners, or `"rectangular"`
62+
* for a progress-bar without rounded corners.
6363
*
6464
* Defaults to `"round"` for the `ionic` theme, undefined for all other themes.
6565
*/
@@ -69,7 +69,7 @@ export class ProgressBar implements ComponentInterface {
6969
const theme = getIonTheme(this);
7070
const { shape } = this;
7171

72-
// TODO(ROU-11436): Remove theme check when shapes are defined for all themes.
72+
// TODO(ROU-11638): Remove theme check when shapes are defined for all themes.
7373
if (theme !== 'ionic') {
7474
return undefined;
7575
}

core/src/components/progress-bar/test/basic/progress-bar.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import { configs, test } from '@utils/test/playwright';
33

4-
configs().forEach(({ title, screenshot, config }) => {
4+
configs({ modes: ['ios', 'md', 'ionic-md'] }).forEach(({ title, screenshot, config }) => {
55
test.describe(title('progress-bar: basic'), () => {
66
test('should not have visual regressions', async ({ page }) => {
77
await page.goto('/src/components/progress-bar/test/basic', config);
Loading
Loading
Loading
Loading
Loading
Loading

0 commit comments

Comments
 (0)