Skip to content

Commit 3002234

Browse files
Apply suggestions from code review
Co-authored-by: Brandy Smith <[email protected]>
1 parent 9d2675e commit 3002234

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

core/src/components/divider/divider.common.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818

1919
/* stylelint-disable */
2020
@include ltr() {
21-
padding-right: var(--padding-end);
21+
padding-right: calc(var(--padding-end) + var(--ion-safe-area-right, 0px));
2222
padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
2323
}
2424

2525
@include rtl() {
2626
padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
27-
padding-left: var(--padding-end);
27+
padding-left: calc(var(--padding-end) + var(--ion-safe-area-left, 0px));
2828
}
2929
/* stylelint-enable */
3030
}

core/src/components/divider/test/basic/divider.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import { configs, test } from '@utils/test/playwright';
33

4-
configs({ directions: ['ltr', 'rtl'], modes: ['ios', 'md', 'ionic-md'] }).forEach(({ config, screenshot, title }) => {
4+
configs({ directions: ['ltr'], modes: ['md', 'ionic-md'] }).forEach(({ config, screenshot, title }) => {
55
test.describe(title('divider: rendering'), () => {
66
test('should not have visual regressions', async ({ page }) => {
77
await page.setContent(

0 commit comments

Comments
 (0)