feat(badge): remove default values.

joselrio · joselrio · commit 32e9bdd228cf · 2025-03-20T10:19:31.000Z
diff --git a/core/src/components/tab-button/tab-button.ionic.scss b/core/src/components/tab-button/tab-button.ionic.scss
@@ -97,28 +97,23 @@
 }
 
 :host ::slotted(ion-badge.badge-vertical-top) {
-  @include globals.position(-2px, null, null, null);
+  @include globals.position(-2px);
 }
 
 :host ::slotted(ion-badge.badge-vertical-top:empty) {
-  @include globals.position(calc(globals.$ion-scale-100 * -1), null, null, null);
+  @include globals.position(calc(globals.$ion-scale-100 * -1));
 }
 
 :host ::slotted(ion-badge.badge-vertical-bottom) {
-  @include globals.position(calc(50% - globals.$ion-scale-200), null, null, null);
+  @include globals.position(calc(50% - globals.$ion-scale-200));
 }
 
 :host ::slotted(ion-badge.badge-vertical-bottom:empty) {
-  @include globals.position(calc(50% - globals.$ion-scale-100), null, null, null);
+  @include globals.position(calc(50% - globals.$ion-scale-100));
 }
 
 :host ::slotted(ion-badge[vertical]:not(:empty)) {
-  @include globals.padding(
-    globals.$ion-scale-100,
-    globals.$ion-scale-100,
-    globals.$ion-scale-100,
-    globals.$ion-scale-100
-  );
+  @include globals.padding(globals.$ion-scale-100);
 
   display: flex;
 
@@ -127,13 +122,13 @@
 }
 
 :host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-top) {
-  @include globals.position(calc(50% - globals.$ion-scale-100), null, null, null);
+  @include globals.position(calc(50% - globals.$ion-scale-100));
 }
 
 :host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom) {
-  @include globals.position(calc(50% + globals.$ion-scale-100), null, null, null);
+  @include globals.position(calc(50% + globals.$ion-scale-100));
 }
 
 :host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom:empty) {
-  @include globals.position(calc(50% + 14px), null, null, null);
+  @include globals.position(calc(50% + 14px));
 }
diff --git a/core/src/components/tab-button/tab-button.ios.scss b/core/src/components/tab-button/tab-button.ios.scss
@@ -38,19 +38,19 @@
 }
 
 :host ::slotted(ion-badge.badge-vertical-top) {
-  @include position($tab-ios-button-badge-top-position, null, null, null);
+  @include position($tab-ios-button-badge-top-position);
 }
 
 :host ::slotted(ion-badge.badge-vertical-top:empty) {
-  @include position($tab-ios-button-badge-top-position-empty, null, null, null);
+  @include position($tab-ios-button-badge-top-position-empty);
 }
 
 :host ::slotted(ion-badge.badge-vertical-bottom) {
-  @include position($tab-ios-button-badge-bottom-position, null, null, null);
+  @include position($tab-ios-button-badge-bottom-position);
 }
 
 :host ::slotted(ion-badge.badge-vertical-bottom:empty) {
-  @include position($tab-ios-button-badge-bottom-position-empty, null, null, null);
+  @include position($tab-ios-button-badge-bottom-position-empty);
 }
 
 :host ::slotted(ion-badge[vertical]:not(:empty)) {
@@ -73,15 +73,15 @@
 }
 
 :host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-top) {
-  @include position($tab-ios-button-icon-bottom-badge-top-position, null, null, null);
+  @include position($tab-ios-button-icon-bottom-badge-top-position);
 }
 
 :host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom) {
-  @include position($tab-ios-button-icon-bottom-badge-bottom-position, null, null, null);
+  @include position($tab-ios-button-icon-bottom-badge-bottom-position);
 }
 
 :host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom:empty) {
-  @include position($tab-ios-button-icon-bottom-badge-bottom-position-empty, null, null, null);
+  @include position($tab-ios-button-icon-bottom-badge-bottom-position-empty);
 }
 
 // iOS Tab Button: Icon
@@ -160,7 +160,7 @@
 
 // Label
 :host(.tab-layout-icon-bottom) ::slotted(ion-label) {
-  @include margin(4px, null, null, null);
+  @include margin(4px);
 }
 
 // iOS Tab Button: Icon Start / End Layout
@@ -186,7 +186,7 @@
 // Badge
 :host(.tab-layout-label-hide) ::slotted(ion-badge),
 :host(.tab-has-icon-only) ::slotted(ion-badge) {
-  @include position(10px, null, null, null);
+  @include position(10px);
 }
 
 // Icon
diff --git a/core/src/components/tab-button/tab-button.md.scss b/core/src/components/tab-button/tab-button.md.scss
@@ -76,11 +76,11 @@
 }
 
 :host ::slotted(ion-badge[vertical="bottom"]) {
-  @include position($tab-button-md-badge-bottom-position, null, null, null);
+  @include position($tab-button-md-badge-bottom-position);
 }
 
 :host ::slotted(ion-badge[vertical="bottom"]:empty) {
-  @include position($tab-button-md-badge-bottom-position-empty, null, null, null);
+  @include position($tab-button-md-badge-bottom-position-empty);
 }
 
 :host(.tab-layout-icon-bottom) ::slotted(ion-badge[vertical="top"]) {
@@ -166,7 +166,7 @@
 // Badge
 :host(.tab-layout-label-hide) ::slotted(ion-badge),
 :host(.tab-has-icon-only) ::slotted(ion-badge) {
-  @include position(16px, null, null, null);
+  @include position(16px);
 }
 
 // Icon

Original file line number	Diff line number	Diff line change
`@@ -97,28 +97,23 @@`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`:host ::slotted(ion-badge.badge-vertical-top) {`
`100`		`- @include globals.position(-2px, null, null, null);`
	`100`	`+ @include globals.position(-2px);`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`:host ::slotted(ion-badge.badge-vertical-top:empty) {`
`104`		`- @include globals.position(calc(globals.$ion-scale-100 * -1), null, null, null);`
	`104`	`+ @include globals.position(calc(globals.$ion-scale-100 * -1));`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`:host ::slotted(ion-badge.badge-vertical-bottom) {`
`108`		`- @include globals.position(calc(50% - globals.$ion-scale-200), null, null, null);`
	`108`	`+ @include globals.position(calc(50% - globals.$ion-scale-200));`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`:host ::slotted(ion-badge.badge-vertical-bottom:empty) {`
`112`		`- @include globals.position(calc(50% - globals.$ion-scale-100), null, null, null);`
	`112`	`+ @include globals.position(calc(50% - globals.$ion-scale-100));`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`:host ::slotted(ion-badge[vertical]:not(:empty)) {`
`116`		`- @include globals.padding(`
`117`		`- globals.$ion-scale-100,`
`118`		`- globals.$ion-scale-100,`
`119`		`- globals.$ion-scale-100,`
`120`		`- globals.$ion-scale-100`
`121`		`- );`
	`116`	`+ @include globals.padding(globals.$ion-scale-100);`
`122`	`117`
`123`	`118`	`display: flex;`
`124`	`119`
`@@ -127,13 +122,13 @@`
`127`	`122`	`}`
`128`	`123`
`129`	`124`	`:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-top) {`
`130`		`- @include globals.position(calc(50% - globals.$ion-scale-100), null, null, null);`
	`125`	`+ @include globals.position(calc(50% - globals.$ion-scale-100));`
`131`	`126`	`}`
`132`	`127`
`133`	`128`	`:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom) {`
`134`		`- @include globals.position(calc(50% + globals.$ion-scale-100), null, null, null);`
	`129`	`+ @include globals.position(calc(50% + globals.$ion-scale-100));`
`135`	`130`	`}`
`136`	`131`
`137`	`132`	`:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom:empty) {`
`138`		`- @include globals.position(calc(50% + 14px), null, null, null);`
	`133`	`+ @include globals.position(calc(50% + 14px));`
`139`	`134`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,19 +38,19 @@`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`:host ::slotted(ion-badge.badge-vertical-top) {`
`41`		`- @include position($tab-ios-button-badge-top-position, null, null, null);`
	`41`	`+ @include position($tab-ios-button-badge-top-position);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`:host ::slotted(ion-badge.badge-vertical-top:empty) {`
`45`		`- @include position($tab-ios-button-badge-top-position-empty, null, null, null);`
	`45`	`+ @include position($tab-ios-button-badge-top-position-empty);`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`:host ::slotted(ion-badge.badge-vertical-bottom) {`
`49`		`- @include position($tab-ios-button-badge-bottom-position, null, null, null);`
	`49`	`+ @include position($tab-ios-button-badge-bottom-position);`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`:host ::slotted(ion-badge.badge-vertical-bottom:empty) {`
`53`		`- @include position($tab-ios-button-badge-bottom-position-empty, null, null, null);`
	`53`	`+ @include position($tab-ios-button-badge-bottom-position-empty);`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`:host ::slotted(ion-badge[vertical]:not(:empty)) {`
`@@ -73,15 +73,15 @@`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-top) {`
`76`		`- @include position($tab-ios-button-icon-bottom-badge-top-position, null, null, null);`
	`76`	`+ @include position($tab-ios-button-icon-bottom-badge-top-position);`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom) {`
`80`		`- @include position($tab-ios-button-icon-bottom-badge-bottom-position, null, null, null);`
	`80`	`+ @include position($tab-ios-button-icon-bottom-badge-bottom-position);`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom:empty) {`
`84`		`- @include position($tab-ios-button-icon-bottom-badge-bottom-position-empty, null, null, null);`
	`84`	`+ @include position($tab-ios-button-icon-bottom-badge-bottom-position-empty);`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`// iOS Tab Button: Icon`
`@@ -160,7 +160,7 @@`
`160`	`160`
`161`	`161`	`// Label`
`162`	`162`	`:host(.tab-layout-icon-bottom) ::slotted(ion-label) {`
`163`		`- @include margin(4px, null, null, null);`
	`163`	`+ @include margin(4px);`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`// iOS Tab Button: Icon Start / End Layout`
`@@ -186,7 +186,7 @@`
`186`	`186`	`// Badge`
`187`	`187`	`:host(.tab-layout-label-hide) ::slotted(ion-badge),`
`188`	`188`	`:host(.tab-has-icon-only) ::slotted(ion-badge) {`
`189`		`- @include position(10px, null, null, null);`
	`189`	`+ @include position(10px);`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`// Icon`
Original file line number	Diff line number	Diff line change
`@@ -76,11 +76,11 @@`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`:host ::slotted(ion-badge[vertical="bottom"]) {`
`79`		`- @include position($tab-button-md-badge-bottom-position, null, null, null);`
	`79`	`+ @include position($tab-button-md-badge-bottom-position);`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`:host ::slotted(ion-badge[vertical="bottom"]:empty) {`
`83`		`- @include position($tab-button-md-badge-bottom-position-empty, null, null, null);`
	`83`	`+ @include position($tab-button-md-badge-bottom-position-empty);`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`:host(.tab-layout-icon-bottom) ::slotted(ion-badge[vertical="top"]) {`
`@@ -166,7 +166,7 @@`
`166`	`166`	`// Badge`
`167`	`167`	`:host(.tab-layout-label-hide) ::slotted(ion-badge),`
`168`	`168`	`:host(.tab-has-icon-only) ::slotted(ion-badge) {`
`169`		`- @include position(16px, null, null, null);`
	`169`	`+ @include position(16px);`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`// Icon`