Skip to content

Commit 32fb17c

Browse files
refactor(button): add ripple effect to ionic theme (#29754)
Co-authored-by: Brandy Carney <[email protected]>
1 parent 210f724 commit 32fb17c

File tree

112 files changed

+197
-320
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

112 files changed

+197
-320
lines changed

core/api.txt

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -398,50 +398,73 @@ ion-button,prop,theme,"ios" | "md" | "ionic",undefined,false,false
398398
ion-button,prop,type,"button" | "reset" | "submit",'button',false,false
399399
ion-button,event,ionBlur,void,true
400400
ion-button,event,ionFocus,void,true
401+
ion-button,css-prop,--background,ionic
401402
ion-button,css-prop,--background,ios
402403
ion-button,css-prop,--background,md
404+
ion-button,css-prop,--background-activated,ionic
403405
ion-button,css-prop,--background-activated,ios
404406
ion-button,css-prop,--background-activated,md
407+
ion-button,css-prop,--background-activated-opacity,ionic
405408
ion-button,css-prop,--background-activated-opacity,ios
406409
ion-button,css-prop,--background-activated-opacity,md
410+
ion-button,css-prop,--background-focused,ionic
407411
ion-button,css-prop,--background-focused,ios
408412
ion-button,css-prop,--background-focused,md
413+
ion-button,css-prop,--background-focused-opacity,ionic
409414
ion-button,css-prop,--background-focused-opacity,ios
410415
ion-button,css-prop,--background-focused-opacity,md
416+
ion-button,css-prop,--background-hover,ionic
411417
ion-button,css-prop,--background-hover,ios
412418
ion-button,css-prop,--background-hover,md
419+
ion-button,css-prop,--background-hover-opacity,ionic
413420
ion-button,css-prop,--background-hover-opacity,ios
414421
ion-button,css-prop,--background-hover-opacity,md
422+
ion-button,css-prop,--border-color,ionic
415423
ion-button,css-prop,--border-color,ios
416424
ion-button,css-prop,--border-color,md
425+
ion-button,css-prop,--border-radius,ionic
417426
ion-button,css-prop,--border-radius,ios
418427
ion-button,css-prop,--border-radius,md
428+
ion-button,css-prop,--border-style,ionic
419429
ion-button,css-prop,--border-style,ios
420430
ion-button,css-prop,--border-style,md
431+
ion-button,css-prop,--border-width,ionic
421432
ion-button,css-prop,--border-width,ios
422433
ion-button,css-prop,--border-width,md
434+
ion-button,css-prop,--box-shadow,ionic
423435
ion-button,css-prop,--box-shadow,ios
424436
ion-button,css-prop,--box-shadow,md
437+
ion-button,css-prop,--color,ionic
425438
ion-button,css-prop,--color,ios
426439
ion-button,css-prop,--color,md
440+
ion-button,css-prop,--color-activated,ionic
427441
ion-button,css-prop,--color-activated,ios
428442
ion-button,css-prop,--color-activated,md
443+
ion-button,css-prop,--color-focused,ionic
429444
ion-button,css-prop,--color-focused,ios
430445
ion-button,css-prop,--color-focused,md
446+
ion-button,css-prop,--color-hover,ionic
431447
ion-button,css-prop,--color-hover,ios
432448
ion-button,css-prop,--color-hover,md
449+
ion-button,css-prop,--opacity,ionic
433450
ion-button,css-prop,--opacity,ios
434451
ion-button,css-prop,--opacity,md
452+
ion-button,css-prop,--padding-bottom,ionic
435453
ion-button,css-prop,--padding-bottom,ios
436454
ion-button,css-prop,--padding-bottom,md
455+
ion-button,css-prop,--padding-end,ionic
437456
ion-button,css-prop,--padding-end,ios
438457
ion-button,css-prop,--padding-end,md
458+
ion-button,css-prop,--padding-start,ionic
439459
ion-button,css-prop,--padding-start,ios
440460
ion-button,css-prop,--padding-start,md
461+
ion-button,css-prop,--padding-top,ionic
441462
ion-button,css-prop,--padding-top,ios
442463
ion-button,css-prop,--padding-top,md
464+
ion-button,css-prop,--ripple-color,ionic
443465
ion-button,css-prop,--ripple-color,ios
444466
ion-button,css-prop,--ripple-color,md
467+
ion-button,css-prop,--transition,ionic
445468
ion-button,css-prop,--transition,ios
446469
ion-button,css-prop,--transition,md
447470
ion-button,part,native

core/src/components/button/button.scss renamed to core/src/components/button/button.common.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@
5151

5252
color: var(--color);
5353

54-
font-family: $font-family-base;
55-
5654
text-align: center;
5755
text-decoration: none;
5856

@@ -217,18 +215,9 @@
217215
// --------------------------------------------------
218216

219217
::slotted(ion-icon) {
220-
font-size: 1.35em;
221218
pointer-events: none;
222219
}
223220

224-
::slotted(ion-icon[slot="start"]) {
225-
@include margin(0, 0.3em, 0, -0.3em);
226-
}
227-
228-
::slotted(ion-icon[slot="end"]) {
229-
@include margin(0, -0.2em, 0, 0.3em);
230-
}
231-
232221
// Button Ripple effect
233222
// --------------------------------------------------
234223

0 commit comments

Comments
 (0)