Skip to content

Commit 33aa8e3

Browse files
thetaPCIonitron
andauthored
chore(alert): remove ion-buttons from tests (#28823)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> `ion-button` is being used as a way to open the alerts. It's not being used to test functionality. When `ion-button` is updated then the screenshots in the alert tests must be updated. This shouldn't happen when `ion-button` isn't necessary to have in these tests. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Replaced `ion-button` with `button` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A --------- Co-authored-by: ionitron <[email protected]>
1 parent 535b8ed commit 33aa8e3

File tree

111 files changed

+111
-41
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

111 files changed

+111
-41
lines changed

core/src/components/action-sheet/test/a11y/index.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@
1919
<main class="ion-padding">
2020
<h1>Action Sheet - A11y</h1>
2121

22-
<ion-button id="bothHeaders" expand="block" onclick="presentBothHeaders()">Both Headers</ion-button>
23-
<ion-button id="subHeaderOnly" expand="block" onclick="presentSubHeaderOnly()">Subheader Only</ion-button>
24-
<ion-button id="noHeaders" expand="block" onclick="presentNoHeaders()">No Headers</ion-button>
25-
<ion-button id="customAria" expand="block" onclick="presentCustomAria()">Custom Aria</ion-button>
26-
<ion-button id="ariaLabelButton" expand="block" onclick="presentAriaLabelButton()">Aria Label Button</ion-button>
27-
<ion-button id="ariaLabelCancelButton" expand="block" onclick="presentAriaLabelCancelButton()"
22+
<ion-button id="bothHeaders" onclick="presentBothHeaders()">Both Headers</ion-button>
23+
<ion-button id="subHeaderOnly" onclick="presentSubHeaderOnly()">Subheader Only</ion-button>
24+
<ion-button id="noHeaders" onclick="presentNoHeaders()">No Headers</ion-button>
25+
<ion-button id="customAria" onclick="presentCustomAria()">Custom Aria</ion-button>
26+
<ion-button id="ariaLabelButton" onclick="presentAriaLabelButton()">Aria Label Button</ion-button>
27+
<ion-button id="ariaLabelCancelButton" onclick="presentAriaLabelCancelButton()"
2828
>Aria Label Cancel Button</ion-button
2929
>
3030
</main>

core/src/components/alert/test/a11y/index.html

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,19 @@
99
<script src="../../../../../scripts/testing/scripts.js"></script>
1010
<script nomodule src="../../../../../dist/ionic/ionic.js"></script>
1111
<script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script>
12+
<style>
13+
main > button {
14+
display: block;
15+
clear: both;
16+
width: 100%;
17+
padding: 12px 8px;
18+
font-size: 1em;
19+
background: #f8f8f8;
20+
border: 1px solid #eee;
21+
border-radius: 4px;
22+
margin-bottom: 8px;
23+
}
24+
</style>
1225
</head>
1326
<script type="module">
1427
import { alertController } from '../../../../dist/ionic/index.esm.js';
@@ -19,13 +32,13 @@
1932
<main class="ion-padding">
2033
<h1>Alert - A11y</h1>
2134

22-
<ion-button id="bothHeaders" expand="block" onclick="presentBothHeaders()">Both Headers</ion-button>
23-
<ion-button id="subHeaderOnly" expand="block" onclick="presentSubHeaderOnly()">Subheader Only</ion-button>
24-
<ion-button id="noHeaders" expand="block" onclick="presentNoHeaders()">No Headers</ion-button>
25-
<ion-button id="noMessage" expand="block" onclick="presentNoMessage()">No Message</ion-button>
26-
<ion-button id="customAria" expand="block" onclick="presentCustomAria()">Custom Aria</ion-button>
27-
<ion-button id="ariaLabelButton" expand="block" onclick="presentAriaLabelButton()">Aria Label Button</ion-button>
28-
<ion-button id="checkbox" expand="block" onclick="presentAlertCheckbox()">Checkbox</ion-button>
35+
<button id="bothHeaders" onclick="presentBothHeaders()">Both Headers</button>
36+
<button id="subHeaderOnly" onclick="presentSubHeaderOnly()">Subheader Only</button>
37+
<button id="noHeaders" onclick="presentNoHeaders()">No Headers</button>
38+
<button id="noMessage" onclick="presentNoMessage()">No Message</button>
39+
<button id="customAria" onclick="presentCustomAria()">Custom Aria</button>
40+
<button id="ariaLabelButton" onclick="presentAriaLabelButton()">Aria Label Button</button>
41+
<button id="checkbox" onclick="presentAlertCheckbox()">Checkbox</button>
2942
</main>
3043

3144
<script>
-1.84 KB
-7.94 KB
-3.73 KB
-1.65 KB
-7.94 KB
-3.89 KB
-3.51 KB
-8.14 KB

0 commit comments

Comments
 (0)