Skip to content

Commit 34e41b3

Browse files
committed
change prop to vertical
1 parent 6b90698 commit 34e41b3

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

core/api.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,10 +314,10 @@ ion-backdrop,event,ionBackdropTap,void,true
314314
ion-badge,shadow
315315
ion-badge,prop,color,"danger" | "dark" | "light" | "medium" | "primary" | "secondary" | "success" | "tertiary" | "warning" | string & Record<never, never> | undefined,undefined,false,true
316316
ion-badge,prop,mode,"ios" | "md",undefined,false,false
317-
ion-badge,prop,position,"bottom" | "top" | undefined,undefined,false,false
318317
ion-badge,prop,shape,"round | rectangular" | "soft" | undefined,undefined,false,false
319318
ion-badge,prop,size,"large" | "medium" | "small" | "xlarge" | "xsmall" | "xxsmall" | undefined,undefined,false,false
320319
ion-badge,prop,theme,"ios" | "md" | "ionic",undefined,false,false
320+
ion-badge,prop,vertical,"bottom" | "top" | undefined,undefined,false,false
321321
ion-badge,css-prop,--background,ionic
322322
ion-badge,css-prop,--background,ios
323323
ion-badge,css-prop,--background,md

core/src/components.d.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -428,10 +428,6 @@ export namespace Components {
428428
* The mode determines the platform behaviors of the component.
429429
*/
430430
"mode"?: "ios" | "md";
431-
/**
432-
* Set to `"top"` to position the badge on top right absolute position of the parent element. Set to `"bottom"` to position the badge on bottom right absolute position of the parent element.
433-
*/
434-
"position"?: 'top' | 'bottom';
435431
/**
436432
* Set to `"rectangular"` for non-rounded corners. Set to `"soft"` for slightly rounded corners. Set to `"round"` for fully rounded corners. Defaults to `"round"` for the `ionic` theme, undefined for all other themes.
437433
*/
@@ -444,6 +440,10 @@ export namespace Components {
444440
* The theme determines the visual appearance of the component.
445441
*/
446442
"theme"?: "ios" | "md" | "ionic";
443+
/**
444+
* Set to `"top"` to position the badge on top right absolute position of the parent element. Set to `"bottom"` to position the badge on bottom right absolute position of the parent element.
445+
*/
446+
"vertical"?: 'top' | 'bottom';
447447
}
448448
interface IonBreadcrumb {
449449
/**
@@ -5796,10 +5796,6 @@ declare namespace LocalJSX {
57965796
* The mode determines the platform behaviors of the component.
57975797
*/
57985798
"mode"?: "ios" | "md";
5799-
/**
5800-
* Set to `"top"` to position the badge on top right absolute position of the parent element. Set to `"bottom"` to position the badge on bottom right absolute position of the parent element.
5801-
*/
5802-
"position"?: 'top' | 'bottom';
58035799
/**
58045800
* Set to `"rectangular"` for non-rounded corners. Set to `"soft"` for slightly rounded corners. Set to `"round"` for fully rounded corners. Defaults to `"round"` for the `ionic` theme, undefined for all other themes.
58055801
*/
@@ -5812,6 +5808,10 @@ declare namespace LocalJSX {
58125808
* The theme determines the visual appearance of the component.
58135809
*/
58145810
"theme"?: "ios" | "md" | "ionic";
5811+
/**
5812+
* Set to `"top"` to position the badge on top right absolute position of the parent element. Set to `"bottom"` to position the badge on bottom right absolute position of the parent element.
5813+
*/
5814+
"vertical"?: 'top' | 'bottom';
58155815
}
58165816
interface IonBreadcrumb {
58175817
/**

core/src/components/badge/badge.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export class Badge implements ComponentInterface {
5151
* Set to `"top"` to position the badge on top right absolute position of the parent element.
5252
* Set to `"bottom"` to position the badge on bottom right absolute position of the parent element.
5353
*/
54-
@Prop() position?: 'top' | 'bottom';
54+
@Prop() vertical?: 'top' | 'bottom';
5555

5656
private getShape(): string | undefined {
5757
const theme = getIonTheme(this);
@@ -95,7 +95,7 @@ export class Badge implements ComponentInterface {
9595
[theme]: true,
9696
[`badge-${shape}`]: shape !== undefined,
9797
[`badge-${size}`]: size !== undefined,
98-
[`badge-${this.position}`]: this.position !== undefined,
98+
[`badge-${this.vertical}`]: this.vertical !== undefined,
9999
})}
100100
>
101101
<slot></slot>

packages/angular/src/directives/proxies.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,14 +261,14 @@ export declare interface IonBackdrop extends Components.IonBackdrop {
261261

262262

263263
@ProxyCmp({
264-
inputs: ['color', 'mode', 'position', 'shape', 'size', 'theme']
264+
inputs: ['color', 'mode', 'shape', 'size', 'theme', 'vertical']
265265
})
266266
@Component({
267267
selector: 'ion-badge',
268268
changeDetection: ChangeDetectionStrategy.OnPush,
269269
template: '<ng-content></ng-content>',
270270
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
271-
inputs: ['color', 'mode', 'position', 'shape', 'size', 'theme'],
271+
inputs: ['color', 'mode', 'shape', 'size', 'theme', 'vertical'],
272272
})
273273
export class IonBadge {
274274
protected el: HTMLElement;

packages/angular/standalone/src/directives/proxies.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,14 +349,14 @@ export declare interface IonBackdrop extends Components.IonBackdrop {
349349

350350
@ProxyCmp({
351351
defineCustomElementFn: defineIonBadge,
352-
inputs: ['color', 'mode', 'position', 'shape', 'size', 'theme']
352+
inputs: ['color', 'mode', 'shape', 'size', 'theme', 'vertical']
353353
})
354354
@Component({
355355
selector: 'ion-badge',
356356
changeDetection: ChangeDetectionStrategy.OnPush,
357357
template: '<ng-content></ng-content>',
358358
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
359-
inputs: ['color', 'mode', 'position', 'shape', 'size', 'theme'],
359+
inputs: ['color', 'mode', 'shape', 'size', 'theme', 'vertical'],
360360
standalone: true
361361
})
362362
export class IonBadge {

packages/vue/src/proxies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export const IonBadge = /*@__PURE__*/ defineContainer<JSX.IonBadge>('ion-badge',
125125
'color',
126126
'shape',
127127
'size',
128-
'position'
128+
'vertical'
129129
]);
130130

131131

0 commit comments

Comments
 (0)