fix: footerAnimation did not exist at gestures initialization.

Author: kumibrr

core/src/components/modal/animations/ios.enter.ts

@@ -41,8 +41,10 @@ export const iosEnterAnimation = (baseEl: HTMLElement, opts: ModalAnimationOptio
     .duration(500)
     .addAnimation([wrapperAnimation])
     .beforeAddWrite(() => {
+      if (!animateContentHeight) return;
+
       const ionFooter = baseEl.querySelector('ion-footer');
-      if (ionFooter) {
+      if (ionFooter && footerAnimation) {
         const footerHeight = ionFooter.clientHeight;
         const clonedFooter = ionFooter.cloneNode(true) as HTMLElement;
         baseEl.shadowRoot!.appendChild(clonedFooter);
@@ -52,16 +54,18 @@ export const iosEnterAnimation = (baseEl: HTMLElement, opts: ModalAnimationOptio
         // the same as the cloned footer height
         const page = baseEl.querySelector('.ion-page') as HTMLElement;
         page.style.setProperty('padding-bottom', `${footerHeight}px`);
-      if (animateContentHeight && footerAnimation) {
         footerAnimation.addElement(root.querySelector('ion-footer')!);
-        baseAnimation.addAnimation(footerAnimation);
-      }
-    }});
+    }
+  });
 
   if (animateContentHeight && contentAnimation) {
     baseAnimation.addAnimation(contentAnimation);
   }
 
+  if (animateContentHeight && footerAnimation) {
+    baseAnimation.addAnimation(footerAnimation);
+  }
+
   if (presentingEl) {
     const isMobile = window.innerWidth < 768;
     const hasCardModal =

core/src/components/modal/animations/md.enter.ts

@@ -43,8 +43,10 @@ export const mdEnterAnimation = (baseEl: HTMLElement, opts: ModalAnimationOption
   .duration(280)
   .addAnimation([backdropAnimation, wrapperAnimation])
   .beforeAddWrite(() => {
+    if (!animateContentHeight) return;
+
     const ionFooter = baseEl.querySelector('ion-footer');
-    if (ionFooter) {
+    if (ionFooter && footerAnimation) {
       const footerHeight = ionFooter.clientHeight;
       const clonedFooter = ionFooter.cloneNode(true) as HTMLElement;
       baseEl.shadowRoot!.appendChild(clonedFooter);
@@ -54,15 +56,17 @@ export const mdEnterAnimation = (baseEl: HTMLElement, opts: ModalAnimationOption
       // the same as the cloned footer height
       const page = baseEl.querySelector('.ion-page') as HTMLElement;
       page.style.setProperty('padding-bottom', `${footerHeight}px`);
-    if (animateContentHeight && footerAnimation) {
       footerAnimation.addElement(root.querySelector('ion-footer')!);
-      baseAnimation.addAnimation(footerAnimation);
-    }
-  }});
+      }
+  });
 
   if (animateContentHeight && contentAnimation) {
     baseAnimation.addAnimation(contentAnimation);
   }
 
+  if (animateContentHeight && footerAnimation) {
+    baseAnimation.addAnimation(footerAnimation);
+  }
+
   return baseAnimation;
 };