Skip to content

Commit 3f4596d

Browse files
author
Tanner Reits
committed
fix(modal): background color & toolbar padding for ionic theme
1 parent 3ccc987 commit 3f4596d

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

core/src/components/modal/modal.ionic.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
// --------------------------------------------------
66

77
:host {
8+
--background: #{globals.$ionic-color-base-white};
9+
--box-shadow: #{globals.$ionic-elevation-300};
810
--backdrop-opacity: 1;
9-
--background: globals.$ionic-base-color-white;
10-
--box-shadow: globals.$ionic-elevation-300;
1111

1212
color: globals.$ionic-color-neutral-1200;
1313
}

core/src/css/ionic/core.ionic.scss

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,12 @@ html.ionic ion-modal ion-footer ion-toolbar:last-of-type {
6565
}
6666

6767
/**
68-
* Add padding on the left and right
69-
* of toolbars while accounting for
70-
* safe area values when in landscape.
68+
* Add additional padding to the left and right of toolbars while accounting
69+
* for the safe area insets.
7170
*/
7271
html.ionic ion-modal ion-toolbar {
73-
--border-color: transparent;
74-
75-
padding-right: calc(var(--ion-safe-area-right) + globals.$ionic-space-400);
76-
padding-left: calc(var(--ion-safe-area-left) + globals.$ionic-space-400);
72+
--padding-start: calc(var(--ion-safe-area-right) + #{globals.$ionic-space-200});
73+
--padding-end: calc(var(--ion-safe-area-left) + #{globals.$ionic-space-200});
7774
}
7875

7976
/**
@@ -84,7 +81,6 @@ html.ionic ion-modal.modal-sheet ion-content {
8481
--padding-start: #{globals.$ionic-space-400};
8582
--padding-end: #{globals.$ionic-space-400};
8683
--padding-bottom: #{globals.$ionic-space-400};
87-
--background: #{globals.$ionic-color-base-white};
8884
}
8985

9086
/**

0 commit comments

Comments
 (0)