Skip to content

Commit 42f3447

Browse files
JoaoFerreira-FrontEndIonitronbrandyscarney
authored
feat(textarea): add styles for textarea solid fill (#30685)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - highlight should only appear on md; - fix some textarea ionic css vars usage; - create sheet for ionic.solid; ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> [fill](https://ionic-framework-git-rou-12225-ionic1.vercel.app/src/components/textarea/test/fill?ionic:theme=ionic) [color](https://ionic-framework-git-rou-12225-ionic1.vercel.app/src/components/textarea/test/color?ionic:theme=ionic) [states](https://ionic-framework-git-rou-12225-ionic1.vercel.app/src/components/textarea/test/states?ionic:theme=ionic) --------- Co-authored-by: ionitron <[email protected]> Co-authored-by: Brandy Smith <[email protected]>
1 parent 4faa1a0 commit 42f3447

17 files changed

+109
-11
lines changed
-307 Bytes
Loading
315 Bytes
Loading
159 Bytes
Loading
44 Bytes
Loading
456 Bytes
Loading
435 Bytes
Loading

core/src/components/textarea/test/states/textarea.e2e.ts

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,31 @@ configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ title, screensh
151151
await expect(container).toHaveScreenshot(screenshot(`textarea-readonly-no-fill`));
152152
});
153153
});
154+
155+
test.describe(title('solid'), () => {
156+
test('should render readonly invalid textarea correctly', async ({ page }) => {
157+
await page.setContent(
158+
`
159+
<div class="container">
160+
<ion-textarea
161+
label="Email"
162+
label-placement="stacked"
163+
164+
helper-text="Enter an email"
165+
counter="true"
166+
maxlength="20"
167+
class="ion-touched ion-invalid"
168+
readonly="true"
169+
></ion-textarea>
170+
</div>
171+
`,
172+
config
173+
);
174+
175+
const container = page.locator('.container');
176+
await expect(container).toHaveScreenshot(screenshot(`textarea-readonly-solid-invalid`));
177+
});
178+
});
154179
});
155180
});
156181
});
-345 Bytes
Loading
-3 Bytes
Loading
-1 Bytes
Loading

0 commit comments

Comments
 (0)