Skip to content

Commit 4d09890

Browse files
authored
fix(datetime): navigating months in RTL works correctly (#29421)
Issue number: resolves #29198 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #27917 I failed to account for RTL. This caused the navigation with the arrow buttons to break because the scroll position was always < 2. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Datetime now checks if the component is in RTL mode when creating the scrollLeft threshold. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent aebf694 commit 4d09890

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

core/src/components/datetime/datetime.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,8 @@ export class Datetime implements ComponentInterface {
900900
* Check below the next line ensures that we did not
901901
* swipe and abort (i.e. we swiped but we are still on the current month).
902902
*/
903-
const month = calendarBodyRef.scrollLeft <= 2 ? startMonth : endMonth;
903+
const condition = isRTL(this.el) ? calendarBodyRef.scrollLeft >= -2 : calendarBodyRef.scrollLeft <= 2;
904+
const month = condition ? startMonth : endMonth;
904905

905906
/**
906907
* The edge of the month must be lined up with

0 commit comments

Comments
 (0)