Skip to content

Commit 4d81c8f

Browse files
authored
fix(modal): set correct backdrop opacity for ionic theme (#29960)
Issue number: resolves internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The backdrop opacity is incorrectly set to 0.7 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Sets backdrop opacity to 1 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> [Preview](https://ionic-framework-pkqwthhvj-ionic1.vercel.app/src/components/modal/test/sheet?ionic:theme=ionic)
1 parent bdb7cd6 commit 4d81c8f

File tree

37 files changed

+2
-1
lines changed

37 files changed

+2
-1
lines changed

core/src/components/modal/modal.ionic.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
:host {
88
--background: #{globals.$ionic-color-base-white};
99
--box-shadow: #{globals.$ionic-elevation-300};
10-
--backdrop-opacity: 0.7;
10+
// Backdrop opacity is 1 because the backdrop's background color has an alpha value
11+
--backdrop-opacity: 1;
1112

1213
color: globals.$ionic-color-neutral-1200;
1314
}
-62 Bytes
Loading
-66 Bytes
Loading
-117 Bytes
Loading
-63 Bytes
Loading
-68 Bytes
Loading
-116 Bytes
Loading
-73 Bytes
Loading
-70 Bytes
Loading
-132 Bytes
Loading

0 commit comments

Comments
 (0)