Skip to content

Commit 512732a

Browse files
committed
feat(badge): remove badge empty size since it's unneeded.
1 parent 06ee460 commit 512732a

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

core/src/components/badge/test/hint/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@
136136
<ion-tab-button tab="tab-four" class="e2eTabFourButton">
137137
<ion-label>Tab Four</ion-label>
138138
<ion-icon name="chatbox"></ion-icon>
139-
<ion-badge size="xxsmall" vertical="top" color="success"></ion-badge>
139+
<ion-badge vertical="top" color="success"></ion-badge>
140140
</ion-tab-button>
141141
</ion-tab-bar>
142142
</div>
@@ -165,7 +165,7 @@
165165
<ion-tab-button tab="tab-four" class="e2eTabFourButton">
166166
<ion-label>Tab Four</ion-label>
167167
<ion-icon name="chatbox"></ion-icon>
168-
<ion-badge size="xxsmall" vertical="bottom" color="success"></ion-badge>
168+
<ion-badge vertical="bottom" color="success"></ion-badge>
169169
</ion-tab-button>
170170
</ion-tab-bar>
171171
</div>
@@ -201,7 +201,7 @@
201201
<ion-tab-button tab="tab-four" class="e2eTabFourButton" layout="icon-bottom">
202202
<ion-label>Tab Four</ion-label>
203203
<ion-icon name="chatbox"></ion-icon>
204-
<ion-badge size="xxsmall" vertical="top" color="success"></ion-badge>
204+
<ion-badge vertical="top" color="success"></ion-badge>
205205
</ion-tab-button>
206206
</ion-tab-bar>
207207
</div>
@@ -230,7 +230,7 @@
230230
<ion-tab-button tab="tab-four" class="e2eTabFourButton" layout="icon-bottom">
231231
<ion-label>Tab Four</ion-label>
232232
<ion-icon name="chatbox"></ion-icon>
233-
<ion-badge size="xxsmall" vertical="bottom" color="success"></ion-badge>
233+
<ion-badge vertical="bottom" color="success"></ion-badge>
234234
</ion-tab-button>
235235
</ion-tab-bar>
236236
</div>

core/src/components/tab-button/tab-button.ionic.scss

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,6 @@
9393
// Tab Button: Badge
9494
// --------------------------------------------------
9595

96-
:host ::slotted(ion-badge:empty) {
97-
@include mixins.padding(0, 0);
98-
99-
min-width: globals.$ion-scale-200;
100-
height: globals.$ion-scale-200;
101-
}
102-
10396
:host ::slotted(ion-badge) {
10497
@include mixins.position($start: calc(50% + globals.$ion-scale-300));
10598
}

0 commit comments

Comments
 (0)