Skip to content

Commit 597dc46

Browse files
committed
fix(snapshots): use default value for cmd line argument
1 parent c63ec2e commit 597dc46

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/actions/test-core-screenshot/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ runs:
4949
# which is why we not using the upload-archive
5050
# composite step here.
5151
run: |
52-
npm run test.e2e.docker.ci ${{ inputs.component }} -- --shard=${{ inputs.shard }}/${{ inputs.totalShards }} --update-snapshots
52+
npm run test.e2e.docker.ci ${{ inputs.component }} -- --shard=${{ inputs.shard }}/${{ inputs.totalShards }} --update-snapshots='changed'
5353
git add src/\*.png --force
5454
mkdir updated-screenshots
5555
cd ../ && rsync -R --progress $(git diff --name-only --cached) core/updated-screenshots

core/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@
9393
"test": "npm run test.spec && npm run test.e2e",
9494
"test.spec": "stencil test --spec --max-workers=2",
9595
"test.e2e": "npx playwright test",
96-
"test.e2e.update-snapshots": "npm run test.e2e -- --update-snapshots",
96+
"test.e2e.update-snapshots": "npm run test.e2e -- --update-snapshots='changed'",
9797
"test.watch": "jest --watch --no-cache",
9898
"test.treeshake": "node scripts/treeshaking.js dist/index.js",
9999
"validate": "npm run lint && npm run test && npm run build && npm run test.treeshake",
100100
"docker.build": "docker build -t ionic-playwright .",
101101
"test.e2e.docker": "npm run docker.build && node ./scripts/docker.mjs",
102-
"test.e2e.docker.update-snapshots": "npm run test.e2e.docker -- --update-snapshots",
102+
"test.e2e.docker.update-snapshots": "npm run test.e2e.docker -- --update-snapshots='changed'",
103103
"test.e2e.docker.ci": "npm run docker.build && CI=true node ./scripts/docker.mjs",
104104
"test.e2e.script": "node scripts/testing/e2e-script.mjs"
105105
},

0 commit comments

Comments
 (0)