Skip to content

Commit 5f29b33

Browse files
- improvements based on review feedback;
1 parent b9663bf commit 5f29b33

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

core/src/components/button/button.ionic.scss

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
// --------------------------------------------------
4444

4545
:host(.button-solid) {
46-
--background-activated: #{globals.$ion-bg-primary-base-press};
47-
--background-hover: #{globals.$ion-bg-primary-base-press};
46+
--background-activated: #{globals.ion-color(primary, shade)};
47+
--background-hover: #{globals.ion-color(primary, shade)};
4848
--background-focused: transparent;
4949
--background-hover-opacity: 1;
5050
--background: #{globals.ion-color(primary, base)};
@@ -85,17 +85,17 @@
8585

8686
// Warning Outline Button - use foreground color for text and border
8787
:host(.button-outline.ion-color-warning) .button-native {
88-
--color: #{globals.ion-color(warning, foreground)};
89-
--border-color: #{globals.ion-color(warning, foreground)};
88+
color: #{globals.current-color(foreground)};
89+
border-color: #{globals.current-color(foreground)};
9090
}
9191

9292
// Clear Button
9393
// --------------------------------------------------
9494

9595
:host(.button-clear) {
96-
--background-activated: #{globals.current-color(shade, $subtle: true)};
96+
--background-activated: #{globals.ion-color(primary, shade, $subtle: true)};
9797
--background-focused: transparent;
98-
--background-hover: #{globals.current-color(shade, $subtle: true)};
98+
--background-hover: #{globals.ion-color(primary, shade, $subtle: true)};
9999
--background-hover-opacity: 1;
100100
--color: #{globals.ion-color(primary, foreground)};
101101
--ripple-opacity: var(--background-activated-opacity, 1);
@@ -105,10 +105,6 @@
105105
:host(.button-clear.ion-color) {
106106
--background-activated: #{globals.current-color(shade, $subtle: true)};
107107
--background-hover: #{globals.current-color(shade, $subtle: true)};
108-
109-
.button-native {
110-
--ion-color-base: #{globals.current-color(foreground)};
111-
}
112108
}
113109

114110
// Button Sizes

0 commit comments

Comments
 (0)