fix(select): select option in desktop Firefox

Adam Bradley · Adam Bradley · commit 65749a40bb87 · 2014-05-13T13:30:32.000-05:00
Closes #1251
diff --git a/js/utils/tap.js b/js/utils/tap.js
@@ -325,7 +325,7 @@ function tapMouseUp(e) {
     return false;
   }
 
-  if( tapIgnoreEvent(e) || e.target.tagName === 'SELECT' ) return false;
+  if( tapIgnoreEvent(e) || (/select|option/i).test(e.target) ) return;
 
   if( !tapHasPointerMoved(e) ) {
     tapClick(e);
@@ -378,7 +378,7 @@ function tapTouchEnd(e) {
   if( !tapHasPointerMoved(e) ) {
     tapClick(e);
 
-    if( e.target.tagName === 'SELECT' ) {
+    if( (/select|option/i).test(e.target) ) {
       e.preventDefault();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ function tapMouseUp(e) {`
`325`	`325`	`return false;`
`326`	`326`	`}`
`327`	`327`
`328`		`- if( tapIgnoreEvent(e) \|\| e.target.tagName === 'SELECT' ) return false;`
	`328`	`+ if( tapIgnoreEvent(e) \|\| (/select\|option/i).test(e.target) ) return;`
`329`	`329`
`330`	`330`	`if( !tapHasPointerMoved(e) ) {`
`331`	`331`	`tapClick(e);`
`@@ -378,7 +378,7 @@ function tapTouchEnd(e) {`
`378`	`378`	`if( !tapHasPointerMoved(e) ) {`
`379`	`379`	`tapClick(e);`
`380`	`380`
`381`		`- if( e.target.tagName === 'SELECT' ) {`
	`381`	`+ if( (/select\|option/i).test(e.target) ) {`
`382`	`382`	`e.preventDefault();`
`383`	`383`	`}`
`384`	`384`	`}`