Skip to content

Commit 68c1775

Browse files
Merge branch 'ROU-12225' of https://github.com/ionic-team/ionic-framework into ROU-12225
2 parents b46fa0f + 5fe5b72 commit 68c1775

File tree

64 files changed

+49
-43
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+49
-43
lines changed

core/src/components/buttons/buttons.ionic.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// --------------------------------------------------
1414

1515
::slotted(*) .button-clear {
16-
--color: #{globals.$ion-primitives-neutral-1200};
16+
--color: #{globals.$ion-text-default};
1717
--background: transparent;
1818
--background-activated: transparent;
1919
--background-focused: transparent;

core/src/components/card-title/card-title.ionic.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// --------------------------------------------------
66

77
:host {
8-
--color: #{globals.$ion-primitives-neutral-1200};
8+
--color: #{globals.$ion-text-default};
99

1010
@include globals.typography(globals.$ion-heading-h5-medium);
1111
}

core/src/components/card/card.ionic.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
// --------------------------------------------------
66

77
:host {
8-
--background: #{globals.$ion-primitives-base-white};
8+
--background: #{globals.$ion-bg-surface-default};
99
--border-width: #{globals.$ion-border-size-025};
1010
--border-color: #{globals.$ion-border-default};
1111
--border-style: #{globals.$ion-border-style-solid};
1212
--border-radius: #{globals.$ion-round-xl};
13-
--color: #{globals.$ion-primitives-neutral-1200};
13+
--color: #{globals.$ion-text-default};
1414
min-width: globals.$ion-scale-2400;
1515

1616
border: var(--border-width) var(--border-style) var(--border-color);

core/src/components/checkbox/checkbox.ionic.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
--checkbox-background: #{globals.$ion-bg-input-default};
3131
--checkbox-background-checked: #{globals.$ion-bg-primary-base-default};
3232
--border-color-checked: #{globals.$ion-semantics-primary-base};
33-
--checkmark-color: #{globals.$ion-primitives-base-white};
33+
--checkmark-color: #{globals.$ion-bg-surface-default};
3434
--transition: none;
3535

3636
z-index: 2;
@@ -60,7 +60,7 @@
6060
}
6161

6262
.label-text-wrapper {
63-
color: globals.$ion-primitives-neutral-1200;
63+
color: globals.$ion-text-default;
6464
}
6565

6666
:host(.in-item) .label-text-wrapper {

core/src/components/chip/chip.ionic.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,13 @@
117117

118118
:host(.chip-bold) {
119119
--background: #{globals.$ion-bg-neutral-bold-default};
120-
--color: #{globals.$ion-primitives-base-white};
120+
--color: #{globals.$ion-bg-surface-default};
121121
}
122122

123123
:host(.chip-outline.chip-bold) {
124124
// TODO(FW-6450): this is a made up design choice based on a
125125
// darker shade of the background color
126-
border-color: globals.$ion-primitives-neutral-1200;
126+
border-color: globals.$ion-text-default;
127127
}
128128

129129
// Chip Colors

core/src/components/datetime/datetime.ionic.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* @prop --focus-ring-color: The color of the ring around the focused element.
1010
* @prop --focus-ring-width: The width of the ring around the focused element.
1111
*/
12-
--background: #{globals.$ion-primitives-base-white};
12+
--background: #{globals.$ion-bg-surface-default};
1313
--focus-ring-color: #{globals.$ion-border-focus-default};
1414
--focus-ring-width: #{globals.$ion-border-radius-025};
1515
}
@@ -140,7 +140,7 @@
140140

141141
height: globals.$ion-scale-1200;
142142

143-
color: globals.$ion-primitives-neutral-1200;
143+
color: globals.$ion-text-default;
144144
}
145145

146146
// Disabled Day
@@ -211,7 +211,7 @@
211211
height: globals.$ion-scale-800;
212212

213213
background-color: globals.$ion-primitives-neutral-100;
214-
color: globals.$ion-primitives-neutral-1200;
214+
color: globals.$ion-text-default;
215215
}
216216

217217
// Calendar / Footer / Action Buttons

core/src/components/datetime/test/custom/datetime.e2e.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
2828
await expect(popover).toHaveScreenshot(screenshot(`datetime-custom-time-picker`));
2929
await expect(timeButton).toHaveScreenshot(screenshot(`datetime-custom-time-button-active`));
3030
});
31-
32-
test('should allow styling calendar days in grid style datetimes', async ({ page }) => {
31+
// TODO (FW-6769): Enable test when its fixed
32+
test.skip('should allow styling calendar days in grid style datetimes', async ({ page }) => {
3333
const datetime = page.locator('#custom-calendar-days');
3434

3535
// Wait for calendar days to be rendered

core/src/components/datetime/test/display/datetime.e2e.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ ti
3030
const datetime = page.locator('ion-datetime');
3131
await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-time-date`));
3232
});
33-
test('time should not have any visual regressions', async ({ page }) => {
33+
// TODO (FW-6769): Enable test when its fixed
34+
test.skip('time should not have any visual regressions', async ({ page }) => {
3435
await page.setContent(
3536
`
3637
<ion-datetime value="2022-02-22T16:30:00" presentation="time"></ion-datetime>
@@ -84,7 +85,8 @@ configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ ti
8485
const datetime = page.locator('ion-datetime');
8586
await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-cover-time-date`));
8687
});
87-
test('time should not have any visual regressions', async ({ page }) => {
88+
// TODO (FW-6769): Enable test when its fixed
89+
test.skip('time should not have any visual regressions', async ({ page }) => {
8890
await page.setContent(
8991
`
9092
<ion-datetime size="cover" value="2022-02-22T16:30:00" presentation="time"></ion-datetime>

core/src/components/datetime/test/show-adjacent-days/datetime.e2e.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ ti
1313
await expect(datetime).toHaveScreenshot(screenshot(`datetime-show-adjacent-days`));
1414
});
1515

16-
test('should not have visual regressions with a custom styled calendar', async ({ page }) => {
16+
// TODO (FW-6769): Enable test when its fixed
17+
test.skip('should not have visual regressions with a custom styled calendar', async ({ page }) => {
1718
await page.goto('/src/components/datetime/test/show-adjacent-days', config);
1819
await page.locator('.datetime-ready').first().waitFor();
1920
const datetime = page.locator('#custom-calendar-days');
-38 Bytes

0 commit comments

Comments
 (0)