chore: apply suggestions from code review

Co-authored-by: Maria Hutt <[email protected]>

Author: OS-martacarlos

core/src/components/button/button.ionic.scss

@@ -267,8 +267,14 @@
   font-size: globals.$ion-font-size-500;
 }
 
+:host(.button-xsmall) ::slotted(ion-icon[slot="start"]),
+:host(.button-xsmall) ::slotted(ion-spinner[slot="start"]),
+:host(.button-xsmall) ::slotted(ion-icon[slot="end"]),
+:host(.button-xsmall) ::slotted(ion-spinner[slot="end"]),
 :host(.button-small) ::slotted(ion-icon[slot="start"]),
-:host(.button-small) ::slotted(ion-spinner[slot="start"]) {
+:host(.button-small) ::slotted(ion-spinner[slot="start"]),
+:host(.button-small) ::slotted(ion-icon[slot="end"]),
+:host(.button-small) ::slotted(ion-spinner[slot="end"]) {
   @include globals.margin-horizontal(null, globals.$ion-space-200);
 }
 
@@ -277,28 +283,18 @@
   @include globals.margin-horizontal(null, globals.$ion-space-250);
 }
 
-:host(.button-large) ::slotted(ion-icon[slot="start"]) {
-  @include globals.margin-horizontal(null, globals.$ion-space-300);
-}
-
-:host(.button-xlarge) ::slotted(ion-spinner[slot="start"]) {
+:host(.button-large) ::slotted(ion-icon[slot="start"]),
+:host(.button-large) ::slotted(ion-spinner[slot="start"]),
+:host(.button-large) ::slotted(ion-icon[slot="end"]),
+:host(.button-large) ::slotted(ion-spinner[slot="end"]),
+:host(.button-xlarge) ::slotted(ion-icon[slot="start"]),
+:host(.button-xlarge) ::slotted(ion-spinner[slot="start"]),
+:host(.button-xlarge) ::slotted(ion-icon[slot="end"]),
+:host(.button-xlarge) ::slotted(ion-spinner[slot="end"]) {
   @include globals.margin-horizontal(null, globals.$ion-space-300);
 }
 
-:host(.button-small) ::slotted(ion-icon[slot="end"]),
-:host(.button-small) ::slotted(ion-spinner[slot="end"]) {
-  @include globals.margin-horizontal(globals.$ion-space-200, null);
-}
-
 ::slotted(ion-icon[slot="end"]),
 ::slotted(ion-spinner[slot="end"]) {
   @include globals.margin-horizontal(globals.$ion-space-250, null);
 }
-
-:host(.button-large) ::slotted(ion-icon[slot="end"]) {
-  @include globals.margin-horizontal(globals.$ion-space-300, null);
-}
-
-:host(.button-xlarge) ::slotted(ion-spinner[slot="end"]) {
-  @include globals.margin-horizontal(globals.$ion-space-300, null);
-}

core/src/components/button/test/spinner/button.e2e.ts

@@ -1,7 +1,7 @@
 import { expect } from '@playwright/test';
 import { configs, test } from '@utils/test/playwright';
 
-configs({ modes: ['ionic-md', 'ionic-ios'] }).forEach(({ config, screenshot, title }) => {
+configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ config, screenshot, title }) => {
   test.describe(title('button: spinner'), () => {
     test('should not have visual regressions', async ({ page }) => {
       await page.goto(`/src/components/button/test/spinner`, config);