fix(inputs): ionChange is fired after updating ngModel

Author: manucorporat

src/util/base-input.ts

@@ -98,6 +98,7 @@ export class BaseInput<T> extends Ion implements CommonInput<T> {
   set value(val: T) {
     if (this._writeValue(val)) {
       this.onChange();
+      this._fireIonChange();
     }
   }
 
@@ -120,9 +121,14 @@ export class BaseInput<T> extends Ion implements CommonInput<T> {
    * @hidden
    */
   writeValue(val: any) {
-    this._writeValue(val);
+    if (this._writeValue(val)) {
+      this._fireIonChange();
+    }
   }
 
+  /**
+   * @hidden
+   */
   _writeValue(val: any): boolean {
     if (isUndefined(val)) {
       return false;
@@ -140,10 +146,16 @@ export class BaseInput<T> extends Ion implements CommonInput<T> {
     this._value = normalized;
     this._inputCheckHasValue(normalized);
     this._inputUpdated();
+    return true;
+  }
+
+  /**
+   * @hidden
+   */
+  _fireIonChange() {
     if (this._init) {
       this._debouncer.debounce(() => this.ionChange.emit(this));
     }
-    return true;
   }
 
   /**
@@ -192,8 +204,6 @@ export class BaseInput<T> extends Ion implements CommonInput<T> {
     if (!this._isFocus) {
       return;
     }
-    // assert(NgZone.isInAngularZone(), 'callback should be zoned');
-
     this._isFocus = false;
     this.ionBlur.emit(this);
     this._inputUpdated();

src/util/input-tester.ts

@@ -104,12 +104,14 @@ function testWriteValue<T>(input: BaseInput<T>, config: TestConfig, isInit: bool
   let ionChangeCalled = 0;
   let OnChangeCalled = 0;
   let OnTouchedCalled = 0;
+  let ngModelValue: any;
 
   // Test ionChange
   let sub = input.ionChange.subscribe((ev: any) => {
     assertEqual(ionChangeCalled, 0, 'ionChange: internal error');
     assertEqual(ev, input, 'ionChange: ev is not the input');
     assertEqual(ev.value, test[1], 'ionChange: value does not match');
+    assertEqual(ngModelValue, test[1], 'ionChange: ngmodel was not updated');
 
     ionChangeCalled++;
   });
@@ -119,7 +121,7 @@ function testWriteValue<T>(input: BaseInput<T>, config: TestConfig, isInit: bool
     assertEqual(OnChangeCalled, 0, 'registerOnChange: internal error');
     assertEqual(input.value, ev, 'registerOnChange: ev output does not match');
     assertEqual(input.value, test[1], 'registerOnChange: value does not match');
-
+    ngModelValue = ev;
     OnChangeCalled++;
   });