Skip to content

Commit 72e9135

Browse files
committed
refactor(select): remove added css vars in favor of parts
1 parent 0c0082c commit 72e9135

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

core/api.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,10 +1653,6 @@ ion-select,css-prop,--border-style,ios
16531653
ion-select,css-prop,--border-style,md
16541654
ion-select,css-prop,--border-width,ios
16551655
ion-select,css-prop,--border-width,md
1656-
ion-select,css-prop,--error-text-color,ios
1657-
ion-select,css-prop,--error-text-color,md
1658-
ion-select,css-prop,--helper-text-color,ios
1659-
ion-select,css-prop,--helper-text-color,md
16601656
ion-select,css-prop,--highlight-color-focused,ios
16611657
ion-select,css-prop,--highlight-color-focused,md
16621658
ion-select,css-prop,--highlight-color-invalid,ios

core/src/components/select/select.scss

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@
2525
* @prop --border-width: Width of the select border
2626
*
2727
* @prop --ripple-color: The color of the ripple effect on MD mode.
28-
*
29-
* @prop --helper-text-color: The color of the supporting text displayed beneath the select when the select is valid.
30-
* @prop --error-text-color: The color of the supporting text displayed beneath the select when the select is invalid and touched.
3128
*/
3229
--padding-top: 0px;
3330
--padding-end: 0px;
@@ -40,8 +37,6 @@
4037
--highlight-color-focused: #{ion-color(primary, base)};
4138
--highlight-color-valid: #{ion-color(success, base)};
4239
--highlight-color-invalid: #{ion-color(danger, base)};
43-
--helper-text-color: #{$text-color-step-300};
44-
--error-text-color: var(--highlight-color-invalid);
4540

4641
/**
4742
* This is a private API that is used to switch
@@ -328,13 +323,13 @@ button {
328323
.select-bottom .error-text {
329324
display: none;
330325

331-
color: var(--error-text-color);
326+
color: var(--highlight-color-invalid);
332327
}
333328

334329
.select-bottom .helper-text {
335330
display: block;
336331

337-
color: var(--helper-text-color);
332+
color: $text-color-step-300;
338333
}
339334

340335
:host(.ion-touched.ion-invalid) .select-bottom .error-text {

0 commit comments

Comments
 (0)