Skip to content

Commit 7babf61

Browse files
authored
test(datetime): remove duplicate test (#28092)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> That particular test is flaky. When going to try and fix the flakiness, I realized that this behavior is already tested by another test. This test presents the `ion-picker-internal` components which are also tested in https://github.com/ionic-team/ionic-framework/blob/7c2b6aed053c47c64e80867991c57903b717e597/core/src/components/datetime/test/custom/datetime.e2e.ts#L10. These show the same components which have the same APIs, so this test shouldn't even be needed. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removed the duplicate test ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent 271b90d commit 7babf61

7 files changed

+0
-10
lines changed

core/src/components/datetime/test/custom/datetime.e2e.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,6 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
1313
await expect(datetime).toHaveScreenshot(screenshot(`datetime-custom-wheel`));
1414
});
1515

16-
test('should allow styling month/year picker in grid style datetimes', async ({ page }) => {
17-
const datetime = page.locator('#custom-grid');
18-
const monthYearToggle = datetime.locator('.calendar-month-year');
19-
20-
await monthYearToggle.click();
21-
await page.waitForChanges();
22-
23-
await expect(datetime).toHaveScreenshot(screenshot(`datetime-custom-month-year`));
24-
});
25-
2616
test('should allow styling time picker in grid style datetimes', async ({ page }) => {
2717
const timeButton = page.locator('ion-datetime .time-body');
2818
const popover = page.locator('.popover-viewport');

0 commit comments

Comments
 (0)