Skip to content

Commit 7c10c4d

Browse files
committed
chore(): update modal tests
1 parent c46d25b commit 7c10c4d

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

ionic/components/alert/test/basic/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ class E2EPage {
234234

235235
setTimeout(() => {
236236
alert.dismiss();
237-
}, 100);
237+
}, 200);
238238
}
239239

240240
doDisabledBackdropAlert() {

ionic/components/menu/test/basic/e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ it('should toggle open menu', function() {
55

66

77
it('should close menu', function() {
8-
element(by.css('[menuClose=left]')).click();
8+
element(by.css('.e2eCloseLeftMenu')).click();
99
});

ionic/components/menu/test/basic/main.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
{{p.title}}
1313
</button>
1414

15-
<button ion-item menuClose="left" detail-none>
15+
<button ion-item menuClose="left" class="e2eCloseLeftMenu" detail-none>
1616
Close Menu
1717
</button>
1818

ionic/components/slides/slides.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,8 +454,7 @@ export class Slides extends Ion {
454454

455455
let zi = new Animation(this.touch.target.children[0])
456456
.duration(this.zoomDuration)
457-
.easing('linear')
458-
.fill('none');
457+
.easing('linear');
459458

460459
let zw = new Animation(this.touch.target.children[0])
461460
.duration(this.zoomDuration)

ionic/util/dom.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,15 @@ export let CSS: {
9191

9292
export function transitionEnd(el: HTMLElement, callback: Function) {
9393
if (el) {
94-
function deregister() {
94+
function unregister() {
9595
CSS.transitionEnd.split(' ').forEach(eventName => {
9696
el.removeEventListener(eventName, onEvent);
9797
});
9898
}
9999

100100
function onEvent(ev) {
101101
if (el === ev.target) {
102-
deregister();
102+
unregister();
103103
callback(ev);
104104
}
105105
}
@@ -108,7 +108,7 @@ export function transitionEnd(el: HTMLElement, callback: Function) {
108108
el.addEventListener(eventName, onEvent);
109109
});
110110

111-
return deregister;
111+
return unregister;
112112
}
113113
}
114114

0 commit comments

Comments
 (0)