Skip to content

Commit 7ecd41f

Browse files
authored
test(radio): skip Safari on legacy tab key tests (#28387)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Legacy radio has tests that use `Tab` key presses. These tend to flake at unknown moments and were skipped until a fix can be implemented. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Unable to replicate the flakiness locally or on GitHub. However, it only fails on Safari so the tests were re-enabled except for Safari. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> This only happens on legacy. The legacy form controls will also be removed in the future. Due to this, these tests will be removed anyways at that time.
1 parent 2b015b2 commit 7ecd41f

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

core/src/components/radio/test/legacy/a11y/radio.e2e.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@ import { configs, test } from '@utils/test/playwright';
66
*/
77
configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
88
test.describe(title('radio: a11y'), () => {
9-
// TODO(FW-5218)
10-
test.fixme('tabbing should switch between radio groups', async ({ page, pageUtils }) => {
9+
test.beforeEach(async ({ page, skip }) => {
10+
skip.browser('webkit', 'Tabbing is flaky in Safari');
1111
await page.goto(`/src/components/radio/test/legacy/a11y`, config);
12-
12+
});
13+
test('tabbing should switch between radio groups', async ({ page, pageUtils }) => {
1314
const firstGroupRadios = page.locator('#first-group ion-radio');
1415
const secondGroupRadios = page.locator('#second-group ion-radio');
1516

@@ -22,10 +23,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
2223
await pageUtils.pressKeys('shift+Tab');
2324
await expect(firstGroupRadios.nth(0)).toBeFocused();
2425
});
25-
// TODO(FW-5218)
26-
test.fixme('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
27-
await page.goto(`/src/components/radio/test/legacy/a11y`, config);
28-
26+
test('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
2927
const firstGroupRadios = page.locator('#first-group ion-radio');
3028

3129
await pageUtils.pressKeys('Tab');

0 commit comments

Comments
 (0)