Skip to content

Commit 7f3273f

Browse files
mapsandappsthetaPC
andauthored
docs(angular test app): include instructions for updating nightly build (#28948)
Issue number: None --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> People adding a new Angular test app don't know they need to update the Stencil nightly build. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Documentation exists for adding a new Angular version to the Stencil nightly build when creating a new Angular test app.. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information This is related to #28945 <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: Maria Hutt <[email protected]>
1 parent e62ec50 commit 7f3273f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

packages/angular/test/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,4 +113,6 @@ Note: You may encounter some other peer dependency issues not covered by the Ang
113113
7. Open `./github/workflows/build.yml` and find the `test-angular-e2e` job.
114114
8. Find the `apps` field under `matrix`.
115115
9. Add "ng14" to the `apps` field.
116-
10. Commit these changes and push.
116+
10. Open `./github/workflows/stencil-nightly.yml` and find the `test-angular-e2e` job.
117+
11. Repeat steps 8 and 9.
118+
12. Commit these changes and push.

0 commit comments

Comments
 (0)