Skip to content

Commit 917b261

Browse files
committed
fix(sheet): changed default footer visibility to original
1 parent 79575c7 commit 917b261

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

core/src/components/modal/animations/ios.enter.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,10 @@ export const iosEnterAnimation = (baseEl: HTMLElement, opts: ModalAnimationOptio
7373
*/
7474
const ionFooterAlreadyAppended = baseEl.shadowRoot!.querySelector('ion-footer');
7575
if (ionFooter && !ionFooterAlreadyAppended) {
76-
const footerHeight = ionFooter.clientHeight;
7776
const clonedFooter = ionFooter.cloneNode(true) as HTMLIonFooterElement;
78-
77+
clonedFooter.style.setProperty('display', 'none');
78+
clonedFooter.setAttribute('aria-hidden', 'true');
7979
baseEl.shadowRoot!.appendChild(clonedFooter);
80-
ionFooter.style.setProperty('display', 'none');
81-
ionFooter.setAttribute('aria-hidden', 'true');
82-
83-
// Padding is added to prevent some content from being hidden.
84-
const page = baseEl.querySelector('.ion-page') as HTMLElement;
85-
page.style.setProperty('padding-bottom', `${footerHeight}px`);
8680
}
8781
});
8882

core/src/components/modal/animations/md.enter.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,10 @@ export const mdEnterAnimation = (baseEl: HTMLElement, opts: ModalAnimationOption
7575
*/
7676
const ionFooterAlreadyAppended = baseEl.shadowRoot!.querySelector('ion-footer');
7777
if (ionFooter && !ionFooterAlreadyAppended) {
78-
const footerHeight = ionFooter.clientHeight;
7978
const clonedFooter = ionFooter.cloneNode(true) as HTMLIonFooterElement;
80-
79+
clonedFooter.style.setProperty('display', 'none');
80+
clonedFooter.setAttribute('aria-hidden', 'true');
8181
baseEl.shadowRoot!.appendChild(clonedFooter);
82-
ionFooter.style.setProperty('display', 'none');
83-
ionFooter.setAttribute('aria-hidden', 'true');
84-
85-
// Padding is added to prevent some content from being hidden.
86-
const page = baseEl.querySelector('.ion-page') as HTMLElement;
87-
page.style.setProperty('padding-bottom', `${footerHeight}px`);
8882
}
8983
});
9084

0 commit comments

Comments
 (0)