Skip to content

Commit 93dcb43

Browse files
committed
refactor(card-content): remove heading styles
1 parent b0ca6b9 commit 93dcb43

File tree

4 files changed

+1
-66
lines changed

4 files changed

+1
-66
lines changed

BREAKING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ This is a comprehensive list of the breaking changes introduced in the major ver
3030

3131
- **ion-card**: The `border-radius` of the `ios` and `md` card now defaults to `14px` and `12px` instead of `8px` and `4px`, respectively, in accordance with the iOS and Material Design 3 guidelines. To revert to the previous appearance, set the `shape` to `"soft"`, or override the `--border-radius` CSS variable to specify a different value.
3232

33-
- **ion-card-content**: The `ion-card-content` component has been updated to Shadow DOM. With this update, all card-related components now use Shadow DOM for style encapsulation.
33+
- **ion-card-content**: The `ion-card-content` component has been updated to Shadow DOM. With this update, all card-related components now use Shadow DOM for style encapsulation. The default styles for heading elements inside `ion-card-content` have been removed. If you need custom styling for headings, you can add your own CSS targeting these elements.
3434

3535
<h4 id="version-9x-chip">Chip</h4>
3636

core/src/components/card-content/card-content.ios.scss

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -12,30 +12,6 @@
1212
line-height: 1.4;
1313
}
1414

15-
::slotted(h1) {
16-
@include margin(0, 0, 2px);
17-
18-
font-size: dynamic-font(24px);
19-
font-weight: normal;
20-
}
21-
22-
::slotted(h2) {
23-
@include margin(2px, 0);
24-
25-
font-size: dynamic-font(16px);
26-
font-weight: normal;
27-
}
28-
29-
::slotted(h3),
30-
::slotted(h4),
31-
::slotted(h5),
32-
::slotted(h6) {
33-
@include margin(2px, 0);
34-
35-
font-size: dynamic-font(14px);
36-
font-weight: normal;
37-
}
38-
3915
::slotted(p) {
4016
@include margin(0, 0, 2px);
4117

core/src/components/card-content/card-content.md.scss

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -12,30 +12,6 @@
1212
line-height: $card-md-line-height;
1313
}
1414

15-
::slotted(h1) {
16-
@include margin(0, 0, 2px);
17-
18-
font-size: dynamic-font(24px);
19-
font-weight: normal;
20-
}
21-
22-
::slotted(h2) {
23-
@include margin(2px, 0);
24-
25-
font-size: dynamic-font(16px);
26-
font-weight: normal;
27-
}
28-
29-
::slotted(h3),
30-
::slotted(h4),
31-
::slotted(h5),
32-
::slotted(h6) {
33-
@include margin(2px, 0);
34-
35-
font-size: dynamic-font(14px);
36-
font-weight: normal;
37-
}
38-
3915
::slotted(p) {
4016
@include margin(0, 0, 2px);
4117

core/src/components/card/test/basic/index.html

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,6 @@
3434
in the woods. Wash your spirit clean.
3535
</ion-card-content>
3636
</ion-card>
37-
38-
<ion-card>
39-
<ion-card-header>
40-
<ion-card-subtitle>Card Subtitle</ion-card-subtitle>
41-
<ion-card-title>Card Title</ion-card-title>
42-
</ion-card-header>
43-
44-
<ion-card-content>
45-
<h1>Heading 1</h1>
46-
<h2>Heading 2</h2>
47-
<h3>Heading 3</h3>
48-
<h4>Heading 4</h4>
49-
<h5>Heading 5</h5>
50-
<h6>Heading 6</h6>
51-
<p>This is a paragraph</p>
52-
</ion-card-content>
53-
</ion-card>
5437
</ion-content>
5538
</ion-app>
5639
</body>

0 commit comments

Comments
 (0)