Commit 9500769
authored
fix(nav): improve reliability of swipe back gesture when quickly swiping back (#27904)
Issue number: resolves #27893
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
This is another instance of
#22895. The
`progressCallback` function is fires asynchronously, so it's possible
for the gesture start and end callbacks to run before the animation is
ever set in `progressCallback`. When this happens, the animation gets
locked up.
I previously fixed this in
#23527 for
`ion-router-outlet`, but I did not fix it for `ion-nav`.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- If the gesture has ended by the time `progressCallback` fires, reset
the animation to the beginning so it does not get locked up.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Dev build: `7.2.2-dev.11690896715.12338339`1 parent 5992c61 commit 9500769
File tree
1 file changed
+36
-5
lines changed1 file changed
+36
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
869 | 869 | | |
870 | 870 | | |
871 | 871 | | |
872 | | - | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
873 | 902 | | |
874 | 903 | | |
875 | 904 | | |
| |||
1008 | 1037 | | |
1009 | 1038 | | |
1010 | 1039 | | |
| 1040 | + | |
1011 | 1041 | | |
1012 | 1042 | | |
1013 | 1043 | | |
1014 | | - | |
1015 | 1044 | | |
1016 | 1045 | | |
1017 | 1046 | | |
1018 | 1047 | | |
1019 | 1048 | | |
| 1049 | + | |
1020 | 1050 | | |
1021 | 1051 | | |
1022 | 1052 | | |
| |||
1028 | 1058 | | |
1029 | 1059 | | |
1030 | 1060 | | |
1031 | | - | |
1032 | 1061 | | |
1033 | 1062 | | |
1034 | | - | |
| 1063 | + | |
1035 | 1064 | | |
1036 | 1065 | | |
1037 | 1066 | | |
| |||
1055 | 1084 | | |
1056 | 1085 | | |
1057 | 1086 | | |
| 1087 | + | |
| 1088 | + | |
1058 | 1089 | | |
1059 | 1090 | | |
1060 | 1091 | | |
| |||
0 commit comments