Skip to content

Commit 9b8e12d

Browse files
committed
fix(picker-column-option): changed structure in order to remove tabindex="-1"
This is needed in order to prevent A11Y issues, in order to prevent to be possible to navigate through each option item through tab navigation, structure must change into this.
1 parent ddc90e2 commit 9b8e12d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

core/src/components/picker-column-option/picker-column-option.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// Picker Column
44
// --------------------------------------------------
55

6-
button {
6+
.picker-column-option-button {
77
@include padding(0);
88
@include margin(0);
99

@@ -40,6 +40,6 @@ button {
4040
opacity: 0.4;
4141
}
4242

43-
:host(.option-disabled) button {
43+
:host(.option-disabled) .picker-column-option-button {
4444
cursor: default;
4545
}

core/src/components/picker-column-option/picker-column-option.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ export class PickerColumnOption implements ComponentInterface {
124124
['option-disabled']: disabled,
125125
})}
126126
>
127-
<button tabindex="-1" aria-label={ariaLabel} disabled={disabled} onClick={() => this.onClick()}>
127+
<div class={"picker-column-option-button"} role="button" aria-label={ariaLabel} onClick={() => this.onClick()}>
128128
<slot></slot>
129-
</button>
129+
</div>
130130
</Host>
131131
);
132132
}

0 commit comments

Comments
 (0)