Skip to content

Commit a42ad86

Browse files
committed
test(action-sheet): add tabIndex, revert styles
1 parent be4a504 commit a42ad86

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

core/src/components/action-sheet/action-sheet.md.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,16 @@
6666
.action-sheet-button {
6767
@include padding($action-sheet-md-button-padding-top, $action-sheet-md-button-padding-end, $action-sheet-md-button-padding-bottom, $action-sheet-md-button-padding-start);
6868

69-
// position: relative;
69+
position: relative;
7070

7171
min-height: $action-sheet-md-button-height;
7272

7373
font-size: $action-sheet-md-button-font-size;
7474

7575
text-align: $action-sheet-md-text-align;
7676

77-
// contain: content;
78-
// overflow: hidden;
77+
contain: content;
78+
overflow: hidden;
7979
}
8080

8181
.action-sheet-icon {

core/src/components/action-sheet/action-sheet.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
flex-shrink: 0;
119119
align-items: center;
120120
justify-content: center;
121-
// pointer-events: none;
121+
pointer-events: none;
122122

123123
width: 100%;
124124
height: 100%;
@@ -177,9 +177,9 @@
177177
// Action Sheet: States
178178
// --------------------------------------------------
179179

180-
// .action-sheet-button::after {
181-
// @include button-state();
182-
// }
180+
.action-sheet-button::after {
181+
@include button-state();
182+
}
183183

184184

185185
// Action Sheet: Selected

core/src/components/action-sheet/action-sheet.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
410410
class={buttonClass(b)}
411411
onClick={() => this.buttonClick(b)}
412412
disabled={b.disabled}
413+
tabIndex={b.disabled ? -1 : 0}
413414
>
414415
<span class="action-sheet-button-inner">
415416
{b.icon && <ion-icon icon={b.icon} aria-hidden="true" lazy={false} class="action-sheet-icon" />}

0 commit comments

Comments
 (0)