Skip to content

Commit add33c5

Browse files
refactor(button): only check for undefined fill (#30722)
Issue number: internal --------- ## What is the current behavior? Button checks for undefined and null fill as a result of Stencil bug stenciljs/core#3586 ## What is the new behavior? - Removes check for `null` with the release of Stencil v4.38.0 - No test needed as one exists already: https://github.com/ionic-team/ionic-framework/pull/26339/files ## Does this introduce a breaking change? - [ ] Yes - [x] No Co-authored-by: Brandy Smith <[email protected]>
1 parent 03303d7 commit add33c5

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

core/src/components/button/button.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -361,11 +361,7 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
361361
target,
362362
};
363363
let fill = this.fill;
364-
/**
365-
* We check both undefined and null to
366-
* work around https://github.com/ionic-team/stencil/issues/3586.
367-
*/
368-
if (fill == null) {
364+
if (fill === undefined) {
369365
fill = this.inToolbar || this.inListHeader ? 'clear' : 'solid';
370366
}
371367

0 commit comments

Comments
 (0)