Skip to content

Commit b2f6b8c

Browse files
BenOsodracIonitron
andauthored
fix(link): improve ionic theme links styles and dev experience (#30375)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adjust link styles to match latest Figma UI and tokens. - For default link, make it work without the need of adding a class. - Change `ionic` to `ion` on the class names. - Adjusted tests to reflect the changes. ## Does this introduce a breaking change? - [] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> - [Ionic Link](https://ionic-framework-git-rou-11850-ionic1.vercel.app/src/css/test/link/basic?ionic:theme=ionic) --------- Co-authored-by: ionitron <[email protected]>
1 parent d3165fc commit b2f6b8c

File tree

33 files changed

+53
-68
lines changed

33 files changed

+53
-68
lines changed

core/src/components/list-header/test/basic/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
Title
4343
<p>With list + link</p>
4444
</ion-label>
45-
<a class="ionic-link" href="#">Clear</a>
45+
<a href="#">Clear</a>
4646
</ion-list-header>
4747
<ion-item lines="none">
4848
<ion-label color="primary">List item</ion-label>
-18 Bytes
Loading
20 Bytes
Loading
32 Bytes
Loading
-19 Bytes
Loading
5 Bytes
Loading
50 Bytes
Loading
-562 Bytes
Loading
-555 Bytes
Loading
-657 Bytes
Loading

0 commit comments

Comments
 (0)