Skip to content

Commit b9b842e

Browse files
author
Adam Bradley
committed
option buttons use onTap instead of onClick
1 parent ae1e339 commit b9b842e

File tree

9 files changed

+12
-14
lines changed

9 files changed

+12
-14
lines changed

dist/css/ionic.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@charset "UTF-8";
21
/*!
32
* Copyright 2013 Drifty Co.
43
* http://drifty.com/

dist/css/ionic.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/css/themes/ionic-ios7.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@charset "UTF-8";
21
/*!
32
* Copyright 2013 Drifty Co.
43
* http://drifty.com/

dist/css/themes/ionic-ios7.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/ionic-angular.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -831,7 +831,7 @@ angular.module('ionic.ui.list', ['ngAnimate'])
831831
<button data-ionic-action="reorder" class="button button-icon icon" ng-class="reorderIconClass"></button>\
832832
</div>\
833833
<div class="item-options" ng-if="itemOptionButtons">\
834-
<button ng-click="b.onClick(item, b)" class="button" ng-class="b.type" ng-repeat="b in itemOptionButtons" ng-bind="b.text"></button>\
834+
<button ng-click="b.onTap(item, b)" class="button" ng-class="b.type" ng-repeat="b in itemOptionButtons" ng-bind="b.text"></button>\
835835
</div>\
836836
</div>',
837837

dist/js/ionic-angular.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/ionic.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/ext/angular/src/directive/ionicList.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ angular.module('ionic.ui.list', ['ngAnimate'])
3131
<button data-ionic-action="reorder" class="button button-icon icon" ng-class="reorderIconClass"></button>\
3232
</div>\
3333
<div class="item-options" ng-if="itemOptionButtons">\
34-
<button ng-click="b.onClick(item, b)" class="button" ng-class="b.type" ng-repeat="b in itemOptionButtons" ng-bind="b.text"></button>\
34+
<button ng-click="b.onTap(item, b)" class="button" ng-class="b.type" ng-repeat="b in itemOptionButtons" ng-bind="b.text"></button>\
3535
</div>\
3636
</div>',
3737

js/ext/angular/test/list.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,22 +178,22 @@ <h2>Nic Cage</h2>
178178
$scope.optionButtons1 = [
179179
{
180180
text: 'Edit',
181-
onClick: function(item, button) { alert(button.text + ' Button: ' + item.text) }
181+
onTap: function(item, button) { alert(button.text + ' Button: ' + item.text) }
182182
},
183183
{
184184
text: 'Share',
185-
onClick: function(item, button) { alert(button.text + ' Button: ' + item.text) }
185+
onTap: function(item, button) { alert(button.text + ' Button: ' + item.text) }
186186
}
187187
];
188188

189189
$scope.optionButtons2 = [
190190
{
191191
text: 'Cancel',
192-
onClick: function() { alert('CANCEL!') }
192+
onTap: function() { alert('CANCEL!') }
193193
},
194194
{
195195
text: 'Submit',
196-
onClick: function() { alert('SUBMIT!') }
196+
onTap: function() { alert('SUBMIT!') }
197197
}
198198
];
199199

0 commit comments

Comments
 (0)